CommonMark.jl icon indicating copy to clipboard operation
CommonMark.jl copied to clipboard

autoidentifiers: Julia 1.0 compat, fix #33

Open fonsp opened this issue 3 years ago • 3 comments

fonsp avatar Dec 17 '21 23:12 fonsp

Let's adjust CI to run on 1.0 - 1.2 as well here to ensure things are compatible with those versions.

I'd like to attempt to retain compat across 1.0 - latest if the maintenance burden isn't too high with needing to patch methods like this. I think we'll need a conditional definition here for get! such that it doesn't cause method overwrite warnings.

MichaelHatherly avatar Dec 19 '21 17:12 MichaelHatherly

There looks to be some other issues on 1.0-1.2 so I think it's simplest to just restrict compat for julia to 1.3 since that's what CI has been testing.

MichaelHatherly avatar Dec 20 '21 08:12 MichaelHatherly

I released MarkdownLiteral with julia = "1.3" :)

https://github.com/JuliaRegistries/General/pull/50958

fonsp avatar Dec 21 '21 13:12 fonsp