DSInternals icon indicating copy to clipboard operation
DSInternals copied to clipboard

Implement searching password hashes using split database

Open aseigler opened this issue 1 year ago • 4 comments

Resolves #185

aseigler avatar Sep 20 '24 21:09 aseigler

Old way:

PS R:\> (Measure-Command { $dsaccounts | Test-PasswordQuality -WeakPasswordHashesSortedFile R:\pwned.txt }).TotalMilliseconds
2141.1098

New way:

PS R:\> (Measure-Command { $dsaccounts | Test-PasswordQuality -WeakPasswordHashesSortedFilePath R:\hibp_files\ }).TotalMilliseconds
850.2169

aseigler avatar Sep 20 '24 21:09 aseigler

Hey @aseigler , thx for this nice PR. Could you please update the markdown documentation for the cmdlet as well, perhaps with an example? I am also not sure, if the command would work properly when both WeakPasswordHashesSortedFile and WeakPasswordHashesSortedFilePath are used.

MichaelGrafnetter avatar Sep 23 '24 16:09 MichaelGrafnetter

Hey @aseigler , thx for this nice PR. Could you please update the markdown documentation for the cmdlet as well, perhaps with an example?

Sure, no problem.

I am also not sure, if the command would work properly when both WeakPasswordHashesSortedFile and WeakPasswordHashesSortedFilePath are used.

This would definitely be an either/or situation, it would make no sense to try to do both in a single command, but checking for that case is simple enough as well.

aseigler avatar Sep 23 '24 17:09 aseigler

Ready for review again.

aseigler avatar Sep 24 '24 12:09 aseigler

Bump. @MichaelGrafnetter

aseigler avatar Oct 21 '24 12:10 aseigler