ColorArt icon indicating copy to clipboard operation
ColorArt copied to clipboard

Added Back Button at DetailActivity for Demo.

Open yelinaung opened this issue 11 years ago • 3 comments

I've added Back Button at DetailActivity for Demo. I just think it's easier. I also added the generated project.properties files. If you don't want it, I can remove and push again. Thanks.

yelinaung avatar Dec 06 '13 15:12 yelinaung

Looks good now, but I'd prefer to not merge PRs with merge commits. If you can fix that, I'll get merge it in :)

MichaelEvans avatar Dec 10 '13 16:12 MichaelEvans

@MichaelEvans Sorry I am a newbie and I don't get what you mean. You mean you want to squash the commits to the last commit ?

yelinaung avatar Dec 10 '13 16:12 yelinaung

No problem! If you look at the commits you've made here, one of them (https://github.com/yelinaung/ColorArt/commit/0ddcae60cfc18e9850443dac8c1ad54f43fd88bb) is a result of a merge commit (http://www.monarchdigital.com/blog/2013-02-08/merge-commits-and-how-prevent-them-git-rebase) You can probably just squash your commits down and add a message explaining what the two do together and that should solve the issue, but going forward that link should be helpful.

MichaelEvans avatar Dec 10 '13 16:12 MichaelEvans