Michael Drogalis

Results 92 comments of Michael Drogalis

Not that I know of, but with the new plugin interface now stable and final, this should be really easy to implement. Should look almost exactly the same as the...

I am fine with improving the feedback from a bad ZooKeeper connection, but there are two problems with the approach in #680: 1. We shouldn't be handling the retry loop...

We're significantly more risk-averse to changes in this part of the code base since it is critical to Onyx being able to run correctly. I would prefer to keep the...

I like that suggestion a lot actually. That seems quite reasonable.

We tried something quite similar in the past for a subcomponent of Onyx -- we were transitioning from a fully isolated resources per virtual peer to multiplexed, shared resources across...

Found it: https://github.com/onyx-platform/onyx/blob/61733d978394c6002f9a4e758f0c0038f5b3a0bd/src/onyx/peer/supervisor.clj

@mariusz-jachimowicz-83 That all said, I still think it's a good idea to have a general Clojure library that can do Component supervision. I don't think it's a good fit for...

Thanks, this is what I had in mind. Also thank you for preemptively splitting out the ZK server, since that needed to be done to clear the way for storing...

@mariusz-jachimowicz-83 Yep. You were on the right track with needing a 2-phased start in order to use Component or Mount. I had to deal with the same thing -- a...

Can't reproduce, perhaps I've got the wrong idea. ``` clojure (ns dire-error.core (:require [robert.hooke :as r] [dire.core :as d])) (defn foo [x] x) (defn microscope [f x] (inc x)) (r/add-hook...