gatsby-remark-embedder
gatsby-remark-embedder copied to clipboard
MichaelDeBoey
feat(Youtube): Add support for height & width options
What: Adds support for passing height & width to the YouTube Transformer.
Why: Makes the transformer more customisable, not everyone wants their videos 100% wide and 315px high? 🤣 Requested by someone else in #144 and is something I require.
How: In the same way as #146
Checklist:
- [x] Documentation
- [x] Tests
- [x] Ready to be merged
Codecov Report
Merging #151 (41d6b9d) into main (668d719) will not change coverage. The diff coverage is
100.00%.
:exclamation: Current head 41d6b9d differs from pull request most recent head 816d3b2. Consider uploading reports for the commit 816d3b2 to get more accurate results
@@ Coverage Diff @@
## main #151 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 16 -1
Lines 300 220 -80
Branches 95 29 -66
=========================================
- Hits 300 220 -80
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/transformers/YouTube.js | 100.00% <100.00%> (ø) |
|
| src/index.js | 100.00% <0.00%> (ø) |
|
| src/transformers/GIPHY.js | 100.00% <0.00%> (ø) |
|
| src/transformers/index.js | 100.00% <0.00%> (ø) |
|
| src/transformers/Slides.js | 100.00% <0.00%> (ø) |
|
| src/transformers/Twitch.js | 100.00% <0.00%> (ø) |
|
| src/transformers/CodePen.js | 100.00% <0.00%> (ø) |
|
| src/transformers/Lichess.js | 100.00% <0.00%> (ø) |
|
| src/transformers/Spotify.js | 100.00% <0.00%> (ø) |
|
| src/transformers/Twitter.js | 100.00% <0.00%> (ø) |
|
| ... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 668d719...816d3b2. Read the comment docs.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
TravisCI seems to have failed on npm install for environment Node.js: node. Not sure how my PR could have caused that, I imagine it's unrelated, let me know if I'm incorrect 😄 .
