gatsby-remark-embedder icon indicating copy to clipboard operation
gatsby-remark-embedder copied to clipboard

Published 20 hours ago • verified publisher icon MichaelDeBoey

feat(Facebook): Add support for Facebook

Open bradgarropy opened this issue 4 years ago • 3 comments

What: Add support for Facebook videos.

Why: Fixes #125.

How: Added src/tranformers/Facebook.js.

Checklist:

  • [x] Documentation
  • [x] Tests
  • [x] Ready to be merged

This is still a work in progress. I created the PR as a draft to reflect that. Any early feedback is appreciated!

bradgarropy avatar Jun 06 '20 05:06 bradgarropy

Codecov Report

Merging #127 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        17    +1     
  Lines          215       221    +6     
  Branches        27        27           
=========================================
+ Hits           215       221    +6
Impacted Files Coverage Δ
src/transformers/index.js 100.00% <ø> (ø)
src/transformers/Facebook.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90ecaf8...184db5d. Read the comment docs.

codecov[bot] avatar Jun 06 '20 05:06 codecov[bot]

@MichaelDeBoey Okay, I think this one is ready to go!

bradgarropy avatar Jun 07 '20 03:06 bradgarropy

Any update on this?

michalkvasnicak avatar Mar 25 '21 08:03 michalkvasnicak