geohashTools icon indicating copy to clipboard operation
geohashTools copied to clipboard

gh_covering should provide geohash name as a variable

Open dshkol opened this issue 4 years ago • 1 comments

Right now using gh_covering only stores geohash names as the rownames attribute. In practice, I find that everytime I use gh_covering, I follow it up like this:

gh_covering(spatial_object, precision = 4) %>% 
  mutate(gh = rownames(.))

Three possible solutions:

  1. Currently the ID variable returns a numeric index. Can replace this with the geohash name as ID as default behaviour
  2. Keep the ID variable and add a gh variable with the name as default behaviour
  3. Do 1/2 if specified with an argument, e.g. labelled = TRUE in the function call

dshkol avatar Jun 23 '20 06:06 dshkol

Just came here to open this exact same issue 🤦

dshkol avatar Nov 02 '20 03:11 dshkol