Michael Chirico
Michael Chirico
Hmm our bug seems to have gone away. I'm not sure when exactly the fix landed, but my best guess is when we fixed an issue where the broken package...
This also applies to the `label=` argument
OK... any plans to deprecate it in those expectations that currently have it?
The `length(dim(.))` check would also pass a `data.frame`... the same applies for just checking exact dimensions. `is.matrix()` allows checking a function returns the right "type" of `m x n` object,...
Related: #1423 :)
Another approach here is to allow all-literal cases where `stringsAsFactors` doesn't matter, e.g. `data.frame(a = 1:3)`, but lint whenever it _might_ matter, e.g. `data.frame(a = a)`.
> Also lintr::lint("does_not_exist.R") would no longer error with file not found. In my preliminary work I have `stop("Expected to find a file name or an R expression, got ", filename)`,...
I don't like that idea, unless we want to use a new lint_text() instead. current API is too convenient for ad hoc work.
but the wrapper can't be quite that thin -- ..1 will become filename which we don't want.