Michael Chirico

Results 389 comments of Michael Chirico

Do you agree that calling it a "drop-in replacement" is problematic? I'm open to other solutions On Sat, Feb 27, 2021, 5:35 AM Jeroen Ooms wrote: > There are many...

I am trying to deprecate `rjson` in favor of `jsonlite` and this is blocking me. `rjson` respects the duplicate names, `jsonlite` apparently applies `make.names`.

Turns out it was the duplicates were unintentional & hitting this surfaced a bug, so don't leave open on account of me; but FWIW, a go script was using the...

Anyone still working on this? Open for PRs?

BTW for the copy-pasters coming here, the invocation should be more accurately be: ``` rhub::check(env_vars = c(`_R_CHECK_TESTS_NLINES_` = '0')) ```

Maybe a more sensible default is something like `_R_CHECK_TESTS_NLINES=100` or even 1000 then? I certainly think 13 is far too few...

SGTM. If you have an FAQ, maybe this would be a good addition at least, otherwise motivated folks like me can find this issue. I leave it to you whether...

I just got bit by this again. I also realize I'm not sure I ever filed a PR on this commit from 1.5 years ago: https://github.com/MichaelChirico/jsonlite/commit/7e41e303d3cccd6b982e69057f4c112f7817d80b

I guess that example was bad... the use case is more like with_debug(foo, bar()) where bar() may call foo() several times

FWIW we found tools::check_packages_in_dir_details() at least does the step of peeling off the "check type" as the Check column. that part at least would be easy... it's parsing the Output...