Michael Chirico

Results 389 comments of Michael Chirico

Would `NULL` be allowed for all of these? I'm thinking of lints that aren't as specific as the line/column level (e.g. file-level lints or line-level lints), which might make sense...

> To be considered for a merge only after the next CRAN release, and before the version is bumped to devel (.9000). Hey @IndrajeetPatil I was following this note and...

we'll just mark it as part of the release process, and Jim will be responsible for merging it in the correct order

@IndrajeetPatil do you want to bump the milestone on this?

Ditto for `c(1:10)`... anything else?

absolutely agree about this. maybe it can be an option to set but I think the default should be failure.

copying notes from the dup'd issue: @IndrajeetPatil: > I love talking about `{lintr}`, but I always find it a tad bit dissatisfying to have slides with just the name of...

we have a different linter for this actually. the linter looks for grepl _and substr_ usages that can become startsWith/endsWith. because of the substr part it got a different linter

using the C version, we just reused is_not_regex after skipping the initial ^

This is mostly handled by `string_boundary_linter`. What's left is to consider regexes like `^static$`, but I am not sure how common they'll be.