Michael Chirico comments

Results 389 comments of


                                            Michael Chirico

simple comment triggers commented_code_linter

By the way, I don't see anything in the style guide about including/excluding code from comments. Should this be a default linter to begin with?

simple comment triggers commented_code_linter

Definitely one option like `allow_no_calls` that requires at least one `(` call seems likely to eliminate many false positives.

Writing R code in a DCF is unappealing

I also find the DCF approach a bit awkward... what's the appeal of it besides back-compatibility?

Writing R code in a DCF is unappealing

the R-based approach just needs `source()` though? maybe I'm not understanding how the R approach is intended to work, exactly

Writing R code in a DCF is unappealing

right... that basically maps to the current setup though right? DCF keys/values --> variable names/values in config environment

Writing R code in a DCF is unappealing

if we're going to switch we could also offer a script (maybe a snippet in NEWS) to convert an existing DCF->R

Writing R code in a DCF is unappealing

I guess this would supersede #886

Add argument `scope = c("function", "variable", "constant", "class", ?)` to `object_name_linter()`

excellent proposal, thanks!

Add argument `scope = c("function", "variable", "constant", "class", ?)` to `object_name_linter()`

everything I could think of was covered in your initial post (well, maybe add S4 classes?)

Add argument `scope = c("function", "variable", "constant", "class", ?)` to `object_name_linter()`

actually I think this linter would to adapt pretty substantially for S4... all the names are in string literals I think (also not an S4 user myself)? see e.g. Matrix...