react-native-form-generator
react-native-form-generator copied to clipboard
Vertical text alignment seems off with React Native 0.33
It maybe related to Centre text in case where the distance between baselines is larger than the font size (68d483e) which seems to effect text lIne height.
I'm going to take a look. Apologies but I didn't have time to do a release in the last weeks. I'm releasing the new version with a lot of fixes and improvements. Thank you
On Sat, Sep 10, 2016, 8:12 PM Jamie Athanassakis [email protected] wrote:
[image: simulator screen shot 11 sep 2016 9 29 34 am] https://cloud.githubusercontent.com/assets/16371427/18414333/d4d193cc-7802-11e6-9dfa-266272ebd5b4.png
It maybe related to Centre text in case where the distance between baselines is larger than the font size (68d483e) https://github.com/facebook/react-native/commit/68d483e04172c4a0da9e41bb9b1aa526e1e9dadd which seems to effect text lIne height.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MichaelCereda/react-native-form-generator/issues/61, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGjfhvXij_VPHGBBUblAx43acxkZvxtks5qo0d3gaJpZM4J53b4 .
Michael Cereda http://michaelcereda.com
@jamieathans I solved it by passing alignItems: 'center' to containerStyles prop.
I also saw this, but I have wrapped all the fields in my own wrapper so it's easy to handle this in one place instead of passing alignItems to every field. I can recommend wrapping the fields. This makes repetitive tasks as for example adding icons to fields, easier.