Michael Bryan

Results 303 comments of Michael Bryan

I've run into this limitation several times and been stumped because it's not possible to dynamically construct a `tracing::Metadata` or `tracing::Event` due to the use of `&'static str` strings. For...

I ran into this issue again a couple weeks back and created [a thread](https://users.rust-lang.org/t/tracing-cant-generate-log-messages-dynamically/76626) on the Rust User Forums. It didn't get any responses, but I think the post itself...

Thanks for the feedback @zekisherif! I think I've addressed the comments you've made. Another thing I'd like to point out is that this PR switches to using `PathBuf` for paths...

I like the idea of using this sort of fluent API. How would the `tracing_appender::filename("/var/log")` call work, though? Does that return an `impl FilenameTemplate` (think `filter()` and `map()` on `Iterator`),...

Instead of `Prefixed` and `WithNameAndExtension`, I've created an `in_directory()` function which takes the log directory and returns a `Template` (a builder type implementing `FilenameTemplate`). By default the `Template` will have...

@davidbarsky, this isn't a breaking change. The previous `RollingFileAppender::new()` constructor hasn't changed signature and now just defers to the `RollingFileAppender::with_custom_template()`, using a `FilenameTemplate` that creates identical filenames to the previous...

> Also tying in the new api more cleanly with the existing RollingFileAppender constructors would be nice instead of having to construct a filename and then calling RollingFileAppender::with_custom_template If you...

> code example should work with current syntax What are your thoughts on using [rust-skeptic] to make sure the README is always up to date? [rust-skeptic]: https://github.com/brson/rust-skeptic

@oli-obk, any chance you can add the "Refactor" label to this?

You may want to hang out until we merge #36. I've gone through and added support for serializing all the serde data types, so we'd end up stepping on each...