Michael Bryan
Michael Bryan
What about replacing the `Geometry` enum with a `Geometry` marker trait? So we could say that anything which implements `Geometry` must implement a set of commonly used algorithm traits. As...
> Will rust-geo provide baseline implementations for all geometries which are currently covered by the enum? I'm assuming that anything in the current `Geometry` enum would implement the `Geometry` trait....
I've added all tests down to ["nested select expression"](https://github.com/projectfluent/fluent.js/blob/6f9eec101cbdf3bff1fa398ce4cd7ab213d8fc31/fluent-syntax/test/serializer_test.js#L354) and they all pass locally. At this point there are no more `unimplemented!()`s so I believe I'm hitting every branch, now...
Thanks @zbraniecki! We'll use git dependencies for now, so that takes the pressure off you. I've implemented all the TypeScript tests and they pass, so this should be identical to...
@zbraniecki, any chance you can review this?
@SirWindfield have you seen [the `fluent_syntax::json` module](https://github.com/projectfluent/fluent-rs/blob/961450bbbfc2b20e9920b5aa1d5384a2dda3922e/fluent-syntax/src/json/mod.rs)? The main reason to also have a manual serializer is because the `serde` serializer API isn't really compatible with a pretty-printer. `serde` works...
> It's not going to be super easy because we don't have a writable AST. Yeah I've already looked into that. A while back I was looking at the fluent...
> It may depend on the use case. fluent-rs is used on the startup of Firefox and that's quite a high number of strings in a very performance-critical area. Thanks,...
> What do you want to send to GT, when, what do you expect to get back, what do you want to do with those results? We currently have English...
@Pike, my final implementation [is available on GitLab](https://gitlab.com/wintech-engineering/fluent-machine-translations), feel free to poke around the code. It works well for our purposes, but I imagine I'll be revisiting it in a...