Micah Zoltu

package.json should use fixed versions.

6

https://github.com/ethereum/solc-js/blob/ee8632967bf1a51602753e113897466e6874be7e/package.json#L47-L57 To protect users against supply chain attacks, package.json should refer to explicit versions and version updates should be done intentionally rather than "when CI happens to build" or "when...

Reduce project dependencies.

9

This is a minor quality of life thing, but at the moment the NPM `solc` package brings with it 77 dependencies. Given the simplicity of this project (just a wrapper...

Adds TypeScript definition for the package's supported public surface area.

16

Note: While this function takes and returns a string, the string is really JSON with a very specific and well defined structure. A future PR will (hopefully) add the definitions...

The `compile` function takes in a string, when really it wants a well described JS object. In JS, this isn't much of a difference but when using something like TypeScript...

Adds Typescript definitions.

20

This isn't complete, but it is _way_ better than nothing and gives a place for people to add additional typescript definitions in the future. Recommend switching over to TypeScript for...

Collect minimum should be useful during initial rounds.

3

https://github.com/status-im/status-network-token/blob/master/migrations/2_deploy_contracts.js#L60-L64 The last parameter, `collectMinimum` is currently set to 10^12. This means that the min per-transaction buy-in is about $0.00035 USD. This is significantly less than the cost of gas...

Do another round of auditing.

1

There have been _substantial_ changes to the contracts since the audits took place. You can see the full diffs here for each audit relative to current master: https://github.com/status-im/status-network-token/compare/2152b17aa2ef584a2aea95533c707a345c6ccf69...master https://github.com/status-im/status-network-token/compare/ef163f1b6fd6fb0630a4b8c78d3b706f3fe1da33...master Included...

Add finalized date to EIPs.

21

Knowing when an EIP became final is often useful as it gives an idea of how long the standard has been in place. For example, I wanted to know when...

One-time NFT Sale of unused EIP numbers.

40

# Problem 1. We could use funding to pay for full time editors. 2. Users want to be able to choose their EIP numbers. 3. We want to maintain credibly...

Pin all GitHub Action dependencies to hash version.

16

All GitHub action references should be like https://github.com/ethereum/EIPs/blob/a182311ee869fa8e5c3e7d4717a1ba5d856be8b4/.github/workflows/auto-merge-bot.yml#L16 Not like https://github.com/ethereum/EIPs/blob/a182311ee869fa8e5c3e7d4717a1ba5d856be8b4/.github/workflows/ci-comment.yml#L15 This protects us from supply chain attacks against this repository as only GitHub (who already has the ability to...