Michał Sikora
Michał Sikora
Ah, yes. I didn't understand it at first. It is in our backlog as an open issue but we don't have immediate plans to implement it.
Yes, it was due to this issue https://github.com/Automattic/pocket-casts-android/issues/2477
Can confirm. iOS handles it this way, and it makes sense to sort it this way.
I'll add that to our internal feature improvements list for bookmarks.
From my testing today while working on syncing this doesn't have 100% reproduction rate. It can happen that the app will get into a state where `Episode` sorting doesn't account...
> Not sure whether I should open another issue in this. Yes, please do. 🙏
If you're asking about my opinion I feel that it is too much but I don't have any problems with having it in the app. I'll ask internally if it...
@zimmerrol We can add it. However, as I mentioned, you need to add support for notifications center and Tasker plugin. Notifications are handled here https://github.com/Automattic/pocket-casts-android/blob/2ea07252cb1b4afc99df966159b87023a0d77664/modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/playback/MediaSessionManager.kt#L435-L462 https://github.com/Automattic/pocket-casts-android/blob/2ea07252cb1b4afc99df966159b87023a0d77664/modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/playback/MediaSessionManager.kt#L738-L750 And Tasker is handled...
These tests are failing ``` [2024-06-07T08:43:11Z] au.com.shiftyjelly.pocketcasts.utils.featureflag.DoubleTest > roundedSpeed respects upper boundary FAILED [2024-06-07T08:43:11Z] junit.framework.AssertionFailedError at DoubleTest.kt:23 [2024-06-07T08:43:11Z] [2024-06-07T08:43:11Z] au.com.shiftyjelly.pocketcasts.utils.featureflag.DoubleTest > roundedSpeed adjusts above upper boundary FAILED [2024-06-07T08:43:11Z] junit.framework.AssertionFailedError at...
Just a thought: wouldn't it be better to run it inside GH Actions? This way it won't occupy any of our Buildkite workers. Or do we want to use Builtkite...