Xiaomi_Kernel_OpenSource icon indicating copy to clipboard operation
Xiaomi_Kernel_OpenSource copied to clipboard

Outdated Source HM Note 3 aka kenzo

Open khanfrd opened this issue 9 years ago • 43 comments

The new Redmi Note 3 uses goodix fingerprint drivers, and the source is outdated so please update the source ASAP

khanfrd avatar Aug 20 '16 13:08 khanfrd

+1

sysxda avatar Aug 20 '16 13:08 sysxda

Guys, can you update source code ?

alesasnouski avatar Aug 22 '16 18:08 alesasnouski

Confirm, please update the source

InfestAl avatar Aug 23 '16 06:08 InfestAl

Update the source code.

happybydefault avatar Aug 25 '16 02:08 happybydefault

This needs urgent attention. Changing hardware has broken certain things on AOSP based ROMs. I think some people are reporting VoLTE and front camera not working?

arhue avatar Aug 25 '16 06:08 arhue

Please update the kernel source. Fingerprint and Front Camera are not working.

roastedwildebeest avatar Aug 25 '16 08:08 roastedwildebeest

Update update update update update!

Tyaginator avatar Aug 25 '16 08:08 Tyaginator

Hi guys, updating the source code would be great. Since new type of fingerprint sensor and front camera are not working in AOSP based ROM. :)

Fosnine avatar Aug 25 '16 08:08 Fosnine

+1

miji2 avatar Aug 25 '16 13:08 miji2

Please update the kernel source. fingerprint sensor and front camera are not working in AOSP based ROM

acnalogia avatar Aug 25 '16 14:08 acnalogia

Update the sources please !! Fingerprint and front camera not working on newer models..

Maria-gr avatar Aug 25 '16 15:08 Maria-gr

Actually it's not that Xiaomi can choose to not update the sources. They are forced to since the kernel uses GPLv2 and they already have distributed the updated kernel to the users. I know copyright doesn't mean anything in China but they have released this product in India so they can be sued for this.

arhue avatar Aug 25 '16 23:08 arhue

Update the source code please!!!

gingerboy92 avatar Aug 26 '16 00:08 gingerboy92

What about front camera ?

alesasnouski avatar Aug 28 '16 16:08 alesasnouski

I have the newer hardware one and don't have any issue with cam on miui

khanfrd avatar Aug 28 '16 17:08 khanfrd

Update the source code please !

yemjalakumar avatar Sep 03 '16 04:09 yemjalakumar

xiaomi , we waiting for u update the source .

Whitexp avatar Sep 03 '16 05:09 Whitexp

Hello, guys. I am a rom developer. Kernel sources by Xiaomi has goodix and front camera driver. Again. Sources by Xiomi is COMPLETE. You can find goodix driver there: https://github.com/MiCode/Xiaomi_Kernel_OpenSource/tree/kenzo-l-oss/drivers/input/misc/goodix So you may ask me why it does not work on custom rom. It does not work because developer of official CM removed goodix driver from kernel sources. Also he removed all files for goodix and front camera in rom. Check my commits: fix of front camera: https://github.com/tank0412/proprietary_vendor_xiaomi/commit/7301b1859bf07805e05a1d844bc6409e124f135a experiments with goodix blobs; https://github.com/tank0412/proprietary_vendor_xiaomi/commit/e90d0ea1aca52490eb8e472a14ccdc782921a57d https://github.com/tank0412/proprietary_vendor_xiaomi/commit/454a8283b8a4a72ccf65fcd4e62e8318457cbbb9 https://github.com/tank0412/proprietary_vendor_xiaomi/commit/0a53dc3432f9bb58b6e0816c886b458fc1e26d10 So it is not a fault of Xiaomi. It is a fault of TheStrix.

P.S. I fixed front camera issue on officail CM builds and published fix. Are you still do not know about it??? http://forum.xda-developers.com/showpost.php?p=68183787&postcount=18

tank0412 avatar Sep 04 '16 17:09 tank0412

Can you give us a link to your PR? Thank you.

alesasnouski avatar Sep 04 '16 17:09 alesasnouski

http://forum.xda-developers.com/showpost.php?p=68183787&postcount=18

tank0412 avatar Sep 04 '16 18:09 tank0412

@tank0412 first of all its no one fault not all the user have goodix fp, and some user reported goodix fp doesn't work on miui too i don't know exactly as i have fpc1020

and yes i am too still confused with TheStrix, i dont know why he use MM blobs, as much i know about roms we can use lp blobs too

and as you say you are rom developer can you help me out with something???

and if any user with goodix can confirm and clean this misunderstanding about goodix fp on miui it will be great help if goodix with custom kernel works on miui then there is no issue with source, will close the issue them

khanfrd avatar Sep 04 '16 19:09 khanfrd

@tank0412 how run gx_fpd? in miui sets fingerprintd and gx_fpd, and fingerprintd from cyanogenmod knows nothing about gx_fpd. it certainly does not belong to the kernel.

alex9yust avatar Sep 04 '16 23:09 alex9yust

"and if any user with goodix can confirm and clean this misunderstanding about goodix fp on miui it will be great help if goodix with custom kernel works on miui then there is no issue with source," I think you should wait for some senior developer to confirm. Regardless if Xiaomi had updated the kernel during the last 5 months after they released the original sources, they have to update the sources to match the released kernel version technically. But I think we can give them a pass on it. Just wait for someone to confirm to sort the issue out.

arhue avatar Sep 05 '16 00:09 arhue

@khanfrd I have phone with goodix fingerprint. And it works on MIUI MM sometimes (but it works) We can use lollipop blobs BUT we need libshims for it and AFAIK RIL does not work on Lollipop blobs. (correct if i wrong) Even if use LP blobs, fingerprint will not work due to major differentces in fingerprint MM API.

tank0412 avatar Sep 05 '16 03:09 tank0412

@tank0412 what about lp?? goodix work with custom kernel on lp??

khanfrd avatar Sep 05 '16 08:09 khanfrd

goodix doesnt work because it is broken! i and @nicknitewolf have tried almost every method to fix goodix fp and we have got to making it appear in the fp settings.

TheStrix removed it because they were not able to fix the issue. Santosh posted his goodix fix but never open sourced it due to which we have to face so many problems.

GuneetAtwal avatar Sep 05 '16 20:09 GuneetAtwal

@GuneetAtwal But Santosh M just port kernel from Miui MM to CM13. Nothing else. So it can not be opensourced.

tank0412 avatar Sep 06 '16 00:09 tank0412

nope, he made a patch for goodix sensor , also his device trees are closed sourced

GuneetAtwal avatar Sep 06 '16 09:09 GuneetAtwal

@GuneetAtwal true. He does not open the source. Even Xiaomi updated their own internal sources of L yet they never release.

niclimcy avatar Sep 06 '16 10:09 niclimcy

@GuneetAtwal Is it some kind of a shim that he has made for the FP API? He is not forced to open source it thanks to the permissive Apache license but we can pressure him to.

arhue avatar Sep 06 '16 10:09 arhue