Mragank Shekhar

> @aghinsa it is still open if you would like to work on it. A PR would be welcome. hi @sjsrey... i just wanted to know if this issue is...

another doubt...for rook=false what will be the the **expected output** for the corner point such as... `m = ps.lib.weights.lat2W(3,3,rook=False)` `m.neighbors[2]` original output is `[1, 5, 4]`

> @MgeeeeK The issue is still open and available. > > For `rook=False` the queen definition applies. So location 2 is in the upper right corner of the lattice, 1...

> Please add a test for integration and to document expected behaviour. I've added a test for the function `lat2W(torus=True)`

@sjsrey should i instead create a new function for `torus` just like `hexLat2W`?

@sjsrey new commits contains: 1. separate function for torus called `torusW` 2. unittests for `torusW` and `hexLat2W` 3. fixes for `lat2SW` (it gave error when `(ncols = 1, criterion =...

This sounds promising @darribas ... I have to figure out the logic for both methods `raster2W/SW`, after finalizing the interface's API this week and adding tests I'll look into the...

Thanks @ljwolf, this is really handy for me to get clear picture of `W` object.

I'd a small doubt related to the first point... `gdf` argument of `plot_spatial_weights()` method accepts only geopandas dataframe, since we're going to make it work with both raster and vector...

I was also thinking of combining weights plot along with the raster plot (like a two column subplots), will add a link to a notebook for showing the prototype.