TwigSpreadsheetBundle icon indicating copy to clipboard operation
TwigSpreadsheetBundle copied to clipboard

Upgrade phpoffice/phpspreadsheet from ~1.3.1 to ^1.5.2

Open kgilden opened this issue 6 years ago • 10 comments

The version of phpoffice/phpspreadsheet should be bumped to fix CVE-2018-19277.

Fixes #18.

kgilden avatar Dec 05 '18 16:12 kgilden

@MewesK hi, do you think we could move forward with this PR?

kgilden avatar Jan 28 '19 12:01 kgilden

Ping @MewesK would be nice if you could merge that one.

xarem avatar Feb 11 '19 13:02 xarem

In the meantime you could modify your composer.json as follows.

{
    "require": {
        "mewesk/twig-spreadsheet-bundle": "dev-upgrade-spreadsheet#fc1b231"
    },
    "repositories": [
        {
            "type": "vcs",
            "url":  "https://github.com/kgilden/twig-spreadsheet-bundle.git"
        }
    ]
}

Running composer update mewesk/twig-spreadsheet-bundle --with-dependencies should do the trick.

kgilden avatar Feb 11 '19 13:02 kgilden

https://github.com/MyWheels/TwigSpreadsheetBundle uses PhpSpreadsheet 1.6.0! you can use that one until @MewesK is active again. @kgilden @xarem

composer require mywheels/twig-spreadsheet-bundle

jamalo avatar Apr 25 '19 13:04 jamalo

Curious to use this package, but not ready to with these old outstanding pulls. Anyone look at this lately?

geoff-maddock avatar Oct 03 '19 17:10 geoff-maddock

@MewesK can you apply this PR, please?

davidromani avatar Dec 23 '19 16:12 davidromani

@MewesK Waiting for the update, please!

JSortGarcia avatar Dec 27 '19 17:12 JSortGarcia

@kgilden @jamalo at some point, after replacing the original vendor by your forks (both) my excel Twig template stopped to fill background colors and border styles.

Is there any problem with this code?

{% xlscell {
                merge: 9,
                style: {
                    borders: {
                        bottom: {
                            style: 'thin',
                            color: {
                                rgb: 'FF0000'
                            }
                        }
                    },
                    fill:
                       type: 'solid',
                       color:
                             rgb: 'D9E2F2'
                       }
                    }
                }
} %} 
    some text cell
{% endxlscell %}

Is related with the phpoffice/phpspreadsheet update?

Any hint, please?

davidromani avatar Jun 09 '20 17:06 davidromani

Is related with the phpoffice/phpspreadsheet update?

Any hint, please?

@davidromani not sure. You could try downgrading by adding "phpoffice/phpspreadsheet": "^1.5.2,<1.6" to your composer.json (or something similar, wrote off top of my head).

kgilden avatar Jun 18 '20 15:06 kgilden

@kgilden for me it's solved, was my mess reading a wrong documentation version. My apologies.

davidromani avatar Jun 18 '20 17:06 davidromani