suicrux icon indicating copy to clipboard operation
suicrux copied to clipboard

Fix double import of babel polyfill

Open diogohmcruz opened this issue 7 years ago β€’ 5 comments

With the import development doesn't work. Without the import production doesn't work.

diogohmcruz avatar Oct 03 '18 15:10 diogohmcruz

Codecov Report

Merging #315 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          10       10           
  Lines          55       55           
  Branches        5        5           
=======================================
  Hits           53       53           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update f89da02...a5e85be. Read the comment docs.

codecov[bot] avatar Oct 03 '18 15:10 codecov[bot]

Hi @BlueDi! I haven't been visiting this repo for a while. Could you explain what does your comment mean? As I understand, removing this import will broke production build?

Metnew avatar Oct 03 '18 22:10 Metnew

@Metnew yes, removing it breaks production, but leaving it breaks development.

diogohmcruz avatar Oct 04 '18 06:10 diogohmcruz

@BlueDi, thanks, I'll take a look asap

Metnew avatar Oct 04 '18 10:10 Metnew

Hi @BlueDi, I've cloned the repo and then build from scratch both dev and prod. It works without any tweak, I guess the issue is on your side. Could you provide more details?

Metnew avatar Oct 09 '18 14:10 Metnew