meteor-client icon indicating copy to clipboard operation
meteor-client copied to clipboard

Fix compatibility with Feather Client

Open IHaxU opened this issue 10 months ago • 23 comments

Type of change

  • [x] Bug fix
  • [ ] New feature

Description

This modifies ChatHudMixin to ensure compatibility between Meteor Client and Feather client. Using @Local in mixins targeting the addVisibleMessage method causes crashes when used alongside Feather. This change removes the use of @Local, instead manually reconstructing the necessary variables to maintain the same functionality.

Related issues

Mention any issues that this pr relates to.

How Has This Been Tested?

https://github.com/user-attachments/assets/d8b51057-64de-4344-a8ca-1a43fba51203

Checklist:

  • [x] My code follows the style guidelines of this project.
  • [x] I have added comments to my code in more complex areas.
  • [x] I have tested the code in both development and production environments.

IHaxU avatar May 30 '25 01:05 IHaxU

I'm opening 3 PRs this week to break feather client more

machiecodes avatar May 30 '25 02:05 machiecodes

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

crosby-moe avatar May 30 '25 03:05 crosby-moe

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

Could you elaborate on this? I duplicated vanilla logic cause onBreakChatMessageLines used a @Local (@Local List<OrderedText> list)

IHaxU avatar May 30 '25 04:05 IHaxU

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

Could you elaborate on this? I duplicated vanilla logic cause onBreakChatMessageLines used a @Local (@Local List<OrderedText> list)

target @At(value = "INVOKE", target = "Ljava/util/List;add(ILjava/lang/Object;)V", remap = false) and capture the argument, this would get the same value as what the @Local that was breaking compat had

crosby-moe avatar May 30 '25 04:05 crosby-moe

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

Could you elaborate on this? I duplicated vanilla logic cause onBreakChatMessageLines used a @Local (@Local List<OrderedText> list)

target @At(value = "INVOKE", target = "Ljava/util/List;add(ILjava/lang/Object;)V", remap = false) and capture the argument, this would get the same value as what the @Local that was breaking compat had

I believe list.get is in the for-loop, while our mixin method is before the for-loop,

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

Could you elaborate on this? I duplicated vanilla logic cause onBreakChatMessageLines used a @Local (@Local List<OrderedText> list)

target @At(value = "INVOKE", target = "Ljava/util/List;add(ILjava/lang/Object;)V", remap = false) and capture the argument, this would get the same value as what the @Local that was breaking compat had

Did I achieve what you wanted correctly in this commit?

IHaxU avatar May 30 '25 05:05 IHaxU

Seems it broke compatibility with the worlds most fragile client (Feather)

IHaxU avatar May 30 '25 05:05 IHaxU

There we go

IHaxU avatar May 30 '25 06:05 IHaxU

Hello, ive been looking forward to using meteor with feather and tried to build this. but it failed to launch and crashed.

heres the log. latest.log

If possible, kindly help me with my request.

SudusaGamer69 avatar Jun 22 '25 10:06 SudusaGamer69

Hello, ive been looking forward to using meteor with feather and tried to build this. but it failed to launch and crashed.

heres the log. latest.log

If possible, kindly help me with my request.

I asked ChatGPT. i got it to run but the GUI is all messed up and stuff. and im constantly autoclicking or some reason? although i did get it to run, tried some modules (worked perfectly fine for some reason)

SudusaGamer69 avatar Jun 23 '25 08:06 SudusaGamer69

Hello, ive been looking forward to using meteor with feather and tried to build this. but it failed to launch and crashed.

heres the log. latest.log

If possible, kindly help me with my request.

wanna send the crash report here from ur crash-reports/ folder? if you want a more direct way to communicate u can reach me on discord: itzjusthim_

IHaxU avatar Jun 27 '25 00:06 IHaxU

how to on meteor client in feather

TheZenGoku avatar Jul 22 '25 07:07 TheZenGoku

Hello, can anyone teach me how to do this pls..

Kezokuu avatar Aug 06 '25 12:08 Kezokuu

Hello, ive been looking forward to using meteor with feather and tried to build this. but it failed to launch and crashed. heres the log. latest.log If possible, kindly help me with my request.

wanna send the crash report here from ur crash-reports/ folder? if you want a more direct way to communicate u can reach me on discord: itzjusthim_

Can you teach me how to do this pls..

Kezokuu avatar Aug 06 '25 12:08 Kezokuu

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

Could you elaborate on this? I duplicated vanilla logic cause onBreakChatMessageLines used a @Local (@Local List<OrderedText> list)

target @At(value = "INVOKE", target = "Ljava/util/List;add(ILjava/lang/Object;)V", remap = false) and capture the argument, this would get the same value as what the @Local that was breaking compat had

Can you teach me how to do it pls...

Kezokuu avatar Aug 06 '25 12:08 Kezokuu

I have got it to run, and it works perfectly fine! but heres a bug i came across:

if you open the ClickGUI in windowed mode, it will glitch out.

My specs are- i3 6100 8gb ddr3 ram integrated graphics

I myself was surprised when it was successfull and really lag free!

SudusaGamer69 avatar Aug 08 '25 06:08 SudusaGamer69

Ok.. soooo could you help me get this into my feather client cause I'm dumb and don't know how to use it

BogTh3Bug avatar Aug 25 '25 21:08 BogTh3Bug

I have got it to run, and it works perfectly fine! but heres a bug i came across:

if you open the ClickGUI in windowed mode, it will glitch out.

My specs are- i3 6100 8gb ddr3 ram integrated graphics

I myself was surprised when it was successfull and really lag free!

HOWW?

BogTh3Bug avatar Aug 26 '25 09:08 BogTh3Bug

Pretty sure there are no artifacts for this build, and myself have left meteor client to try out more ghost clients, but you can build it on your own by the help of chatgpt.

After building, there necessarily arent any dependencies (I think so) Anyways, try asking chatgpt to build this pull. I, myself took help from chatgpt.

The version SHOULD be 1.21.5 but make sure to check by opening the jar file in winrar and check the fabric.mod.json something

SudusaGamer69 avatar Aug 27 '25 05:08 SudusaGamer69

how do i use this?

Ar3fn avatar Sep 02 '25 07:09 Ar3fn

Pretty sure there are no artifacts for this build, and myself have left meteor client to try out more ghost clients, but you can build it on your own by the help of chatgpt.

After building, there necessarily arent any dependencies (I think so) Anyways, try asking chatgpt to build this pull. I, myself took help from chatgpt.

The version SHOULD be 1.21.5 but make sure to check by opening the jar file in winrar and check the fabric.mod.json something

I asked ghatgpt before and made me bat files, texts and all the ways but it didn't work and if I tell him to just send me the final version he said that he can't bc it's cheats.. is it because I send the jar file of meteor that's 1.21.8 with this fork? Cause maybe this fork doesent work with 1.21.8

BogTh3Bug avatar Sep 02 '25 11:09 BogTh3Bug

can you send me meteor 1.21.4 file that works with feather?

huongmai020981-ship-it avatar Sep 30 '25 07:09 huongmai020981-ship-it

My feather is still not working with meteor

Here is the crash report:

Incompatible mods found! net.fabricmc.loader.impl.FormattedException: Some of your mods are incompatible with the game or each other! A potential solution has been determined, this may resolve your problem: - Replace mod 'Meteor Client' (meteor-client) 1.21.4-42 with any version that is compatible with: - feather release/1db97c3d More details: - Mod 'Meteor Client' (meteor-client) 1.21.4-42 is incompatible with any version of mod 'Feather Client' (feather), but a matching version is present: release/1db97c3d! at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:51) at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:202) at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:142) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:66) at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:28) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source) at java.base/java.lang.reflect.Method.invoke(Unknown Source) at net.digitalingot.rustextension.ProxiedStart.main(ProxiedStart.java:27)

If anyone can help me i would be happy

Littlelegamer45 avatar Oct 26 '25 19:10 Littlelegamer45

How can you download in the new version of 1.21.10

Loppaw avatar Nov 03 '25 22:11 Loppaw