meteor-client icon indicating copy to clipboard operation
meteor-client copied to clipboard

Jesus improvements

Open crazycat256 opened this issue 2 years ago • 2 comments

Type of change

  • [x] Bug fix
  • [ ] New feature

Description

This pull request brings the following modifications to the Jesus module:

  • Disables the behavior where a player surfaces while swimming
  • Fixes the issue where the player wasn't being pulled by bubble columns (but still allows upward swimming in magma block bubble columns)
  • Resolves the problem where the player couldn't jump out of water while in a current
  • Addresses the issue where the player couldn't enter water from the side

How Has This Been Tested?

In water, lava, snow powder, bubble columns and waterlogged blocks with both solid and bob mode

Checklist:

  • [x] My code follows the style guidelines of this project.
  • [x] I have added comments to my code in more complex areas.
  • [x] I have tested the code in both development and production environments.

crazycat256 avatar Jan 10 '24 15:01 crazycat256

Are you sure implementing the isTouchingBubbleColumn method is necessary? I would have assumed there would be a method already present in minecraft to do that. Could try one of the methods in mc.world similar to getBlockCollisions, or just find where bubble column movement is handled in the Player entity classes and see how it detects you're in a bubble column there.

Wide-Cat avatar Jan 11 '24 19:01 Wide-Cat

Are you sure implementing the isTouchingBubbleColumn method is necessary? I would have assumed there would be a method already present in minecraft to do that. Could try one of the methods in mc.world similar to getBlockCollisions, or just find where bubble column movement is handled in the Player entity classes and see how it detects you're in a bubble column there.

@Wide-Cat after searching, there seems to be no method that lets you know if a player is touching a bubble column (mc.world.getBlockCollisions doesn't work because there are no collisions with fluids). However, I was able to get around this by using a mixin.

crazycat256 avatar Jan 11 '24 21:01 crazycat256