meteor-client icon indicating copy to clipboard operation
meteor-client copied to clipboard

Pause on Baritone now also works when not pathing for KillAura and BowAimbot

Open RedCarlos26 opened this issue 3 years ago • 9 comments

RedCarlos26 avatar Jul 20 '22 05:07 RedCarlos26

Why is there apparently issues not even related to my code changes 🤔

RedCarlos26 avatar Jul 20 '22 05:07 RedCarlos26

Should I also rename the wasPathing variables to wasBaritone for more consistency, especially that now it doesn't pause only when pathing?

RedCarlos26 avatar Jul 20 '22 05:07 RedCarlos26

Should I also rename the wasPathing variables to wasBaritone for more consistency, especially that now it doesn't pause only when pathing?

Yeah go for it.

ghost avatar Jul 20 '22 16:07 ghost

Why tho

MineGame159 avatar Jul 21 '22 14:07 MineGame159

When using baritone to clear an area it's useful when it can actually pause to attack the entity then go back to work

RedCarlos26 avatar Jul 21 '22 16:07 RedCarlos26

Then the check should be improved instead of fully removing it.

MineGame159 avatar Jul 21 '22 16:07 MineGame159

Why improved? It's useless... Whatever try e process it we want to pause baritone when this is enabled like what?

RedCarlos26 avatar Jul 21 '22 17:07 RedCarlos26

Then the check should be improved instead of fully removing it.

Yeah thats valid if the check isn't useless. The check checks wether baritone is on and pathing but why would would it make a difference if you are pathing. You don't want to be swinging your pickaxe trying to use aura or autoeat. This PR is an extension of #2551.

ghost avatar Jul 22 '22 07:07 ghost

@MineGame159 what do you mean by improving the check btw

RedCarlos26 avatar Jul 29 '22 00:07 RedCarlos26