Migrate for Meteor 3.0

[jankapunkt]

Continuing from #309

[jankapunkt]

Once CI runs we should release a beta asap, wdyt @StorytellerCZ

[StorytellerCZ]

Merged in from #309 as I couldn't push to the original branch for some reason. There are several breaking changes.

[StorytellerCZ]

@bhunjadi I will be watching your fork if anything comes up. I will release a beta shortly, but given that the tests and lint fail we have to look into that @jankapunkt

[StorytellerCZ]

Lint is working and green again!

[StorytellerCZ]

Published matb33:[email protected]

@jankapunkt run into the Meteor version mismatch issue that you were complaining in the past. I think that might also be what is screwing the tests locally.

[StorytellerCZ]

So I managed to get the tests running with the release flag locally. Still have a lot of them stuck and one error. @jankapunkt I think we need to add script for running the test in GitHub Actions properly. I don't remember now which package would be best for that. While at it we should probably standardize this for all the packages that use TinyTests.

[harryadel]

Now the test suit is running properly, at first it wasn't running due to a missing dependency (jquery) and later on it was getting stuck as an async test was still waiting but nothing was being returned.

cc @StorytellerCZ @jankapunkt @bhunjadi

[StorytellerCZ]

@harryadel perfect! Now we'll merge @bhunjadi latest improvements and then fix remaining tests. We can then release an RC and the last thing remaining will be documentation and migration guide.

[StorytellerCZ]

@bhunjadi changes merged, so now we need to fix any broken tests. Either way I will try to release a new beta today.

[harryadel]

cc @StorytellerCZ @bhunjadi

There was a failing test I had to fix. The tests checks for the removal of documents by counting the number of documents, and something causes multiple entries yet the removed document is gone so the test got reworked to just check for that.

I'm going to attempt a new release if I've the rights, if not then it's on you @StorytellerCZ to have a new release today!

[StorytellerCZ]

Will do!

[StorytellerCZ]

Thanks to @jankapunkt for doing the release!

[brianlukoff]

I'm getting this error from montiapm:agent on startup with the RC (wasn't getting the error with the previous beta):

TypeError: Cannot read properties of undefined (reading 'prototype')
    at hijackNextObject (packages/montiapm:agent/lib/hijack/db/hijack-next-object.js:6:42)
    at hijackDBOps (packages/montiapm:agent/lib/hijack/db/index.js:46:3)
    at packages/montiapm:agent/lib/hijack/instrument.js:53:5
    at initAsync (packages/montiapm:meteorx/src/server.js:40:11)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at /tools/static-assets/server/boot.js:453:5
    at /tools/static-assets/server/boot.js:504:7
    at startServerProcess (/tools/static-assets/server/boot.js:501:3)

[jankapunkt]

The question is now, whether this is to be fixed here or in montiapm:agent @StorytellerCZ @harryadel @zodern

[StorytellerCZ]

I think if everyone is happy with the current state we can go for a final release. Thoughts @jankapunkt @harryadel @brianlukoff ?

[brianlukoff]

Unfortunately I am still getting the Monti APM error above running the RC; the beta 2 release works fine.

[harryadel]

@StorytellerCZ I'd rather that we hold out a bit, not only because of the Monti issue but the latest version was causing errors at our application and downgrading was the only fix. So, we need to wait a bit until more people give this a spin.

[StorytellerCZ]

@harryadel yes, we need to fix the tests as well. I will release another RC with the Meteor 3 final release in versions from.

[StorytellerCZ]

@jankapunkt 2.14 tests are failing. Not a bit issue, but it would be good to have a backward compatibility or figure out why. For myself it is not a release blocker as 3.0 tests pass. So the only real thing that we need to figure out is the MontiAPM issue that @harryadel and @brianlukoff spoke of.