Meteor-CollectionFS icon indicating copy to clipboard operation
Meteor-CollectionFS copied to clipboard

Looking for maintainers - please reach out!

Open raix opened this issue 6 years ago • 12 comments

The best packages are the ones maintained by those using it

raix avatar Dec 13 '18 22:12 raix

We are using the Meteor-CollectionFS, Thanks. I can maintain it.

jacky-cyber avatar Dec 30 '18 03:12 jacky-cyber

Sounds great to have you on board @ljshj I'll add you to the repo - what is your Meteor login name (I'll add publish access)

raix avatar Jan 02 '19 17:01 raix

My Meteor login name is ljshj too.

jacky-cyber avatar Jan 05 '19 15:01 jacky-cyber

@ljshj I've added you to the organisation and meteor group - this should enable you to create new releases etc. let me know if it doesn't work - thanks!

raix avatar Jan 06 '19 18:01 raix

@harryadel is also added as maintainer @ljshj - if you have questions along the way ping me or other contributors :)

raix avatar Jan 09 '19 19:01 raix

Hi @ljshj, Looking forward to doing great work with you! A review is needed here.

harryadel avatar Jan 09 '19 22:01 harryadel

@harryadel Thanks. I will review it.

jacky-cyber avatar Jan 10 '19 01:01 jacky-cyber

When the number of the file records is over 10,000 , the cpu usage will be very high, I want to modify its watch mode. @raix

jacky-cyber avatar Jan 10 '19 01:01 jacky-cyber

@ljshj thats an issue with Meteor.Collection subscription right?

raix avatar Jan 10 '19 07:01 raix

@raix I think so too. For example, https://github.com/CollectionFS/Meteor-CollectionFS/blob/bfd5852b257ae8b35c749f34ddb12c3b0cf73a19/packages/collection/common.js#L140, When the number of the file records is over 10,000 , the observe's performance is bad.

jacky-cyber avatar Jan 10 '19 12:01 jacky-cyber

@ljshj ideally we would tap into the oplog query listener - I think @mitar amongst others ran into this issue.

raix avatar Jan 10 '19 18:01 raix

@ljshj You mean the observe initialization performance is bad? BTW, do you need whole observe there or would it observeChanges be enough? For removing you probably just need _id, no? observeChanges provide you with that.

mitar avatar Jan 10 '19 22:01 mitar