Metamogul
Use primary and secondary colors
Hey @aonez, thanks for the contribution! I've tested your addition and it seems like there's still a few elements where text colors are still not compatible with dark mode. You'll find them when quickly searching through the project for Color. Specifically two occurrences of Color.black make that text really hard to read in dark mode. Would you mind changing these too so I can happily merge your MR?
@Metamogul I did a search for Color before the PR and did not found more places other that here:
https://github.com/Metamogul/UTM-Snapshot-Manager/blob/9b6b1beeb315ce01621fa68436cb8385205baaab/UTM%20Snapshot-Manager/UI/VMSectionView.swift#L74-L75
But since it is for a custom button with pink I did not changed that, it looks ok (pink is questionable for standard colors). Can you point me where should be those other occurences?
@aonez Sure, no problem. Use Cmd+Shift+F (or whatever you mapped the project-wide search to) to open the search menu, and search for color. You'll find numerous uses of Color.black or Color.white instead of Color.primary or Color.secondary, e.g. in the VMSectionView.swift. Using the preview function of Xcode to inspect the result for this specific view and cycling in between dark and bright mode you'll see how the text is nicely readable in bright mode, but black on dark grey doesn't work so well for the text in dark mode. There's more examples for hard to read text when using dark mode. Let me know if this helps you fixing the remaining issues with colors and dark mode.