metacello icon indicating copy to clipboard operation
metacello copied to clipboard

Published 20 hours ago • verified publisher icon Metacello

fix for issue #400. add warning if #cacheRepository: is set when loa…

Open pdebruic opened this issue 5 years ago • 4 comments

…ding

Also fix the BaselineOf so it can load into Pharo7.

pdebruic avatar Feb 05 '19 16:02 pdebruic

@pdebruic sorry for the delay in looking at this PR ... you've changed the baseline to allow pharo 7.0 to be loaded, however, the .travis.yml file doesn't have a pharo-7.0 test entry, so we're not getting coverage for pharo-7.0 itself?

dalehenrich avatar Sep 17 '19 23:09 dalehenrich

So I missed a step? I should add pharo-7 to the travis.yml file and add that change to the PR right?

pdebruic avatar Sep 18 '19 04:09 pdebruic

@pdebruic, yes then we can validate that the load will work ...

dalehenrich avatar Sep 18 '19 16:09 dalehenrich

Looking at test results Pharo-6.1 is an expected failure for a big chunk of tests (and a big chunk of tests are failing) ... so I'm not sure that Pharo-7.0 will fare that much better, but it is worth a try I guess ... but post Pharo-6.0 all of the pharo versions are expected failures ... it may be that the iceberg mods are over-ridden by the new version of Metacello and that breaks the entire system ... I'm not sure ...

dalehenrich avatar Sep 18 '19 18:09 dalehenrich