core icon indicating copy to clipboard operation
core copied to clipboard

Deprecate IAttribute::modelSaved()?

Open richardhj opened this issue 8 years ago • 2 comments

The modelSaved method is not called reliable, i.e. as for the alias generation (see comments 1-3 at https://github.com/MetaModels/contao-frontend-editing/issues/6).

We can a) deprecate the modelSaved() and switch to the pre-persist event of the DCG. Problem: The event has no knowledge of its prior value, and an alias value might be overwritten even if already present in the database. b) pass the up-to-date data to the modelSaved(). Problem: more time costs at runtime

(@discordier feel free to edit this post)

richardhj avatar Aug 29 '17 22:08 richardhj

We must re-evaluate if the event will solve the problem, as it might not work anymore as dcg now clears values depending on extra "alwaysSave" etc.

discordier avatar Feb 22 '18 21:02 discordier

@discordier is this obsolete? the attribute alias works fine at FEE

zonky2 avatar Aug 23 '22 19:08 zonky2