snaps icon indicating copy to clipboard operation
snaps copied to clipboard

chore: Refactor cronjob controller

Open hmalik88 opened this issue 1 year ago • 1 comments

Refactors the CronjobController logic to deduplicate logic being used across cronjobs and background events.

hmalik88 avatar Jan 21 '25 15:01 hmalik88

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.02%. Comparing base (4cd200d) to head (c059dd1). Report is 108 commits behind head on main.

Files with missing lines Patch % Lines
...snaps-controllers/src/cronjob/CronjobController.ts 96.15% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3029      +/-   ##
==========================================
+ Coverage   94.98%   95.02%   +0.03%     
==========================================
  Files         511      511              
  Lines       11313    11312       -1     
  Branches     1741     1742       +1     
==========================================
+ Hits        10746    10749       +3     
+ Misses        567      563       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 21 '25 18:01 codecov[bot]

Closing in favor of https://github.com/MetaMask/snaps/pull/3421

FrederikBolding avatar May 27 '25 07:05 FrederikBolding