snaps icon indicating copy to clipboard operation
snaps copied to clipboard

Add platform version field to manifest

Open Mrtenz opened this issue 1 year ago • 1 comments

This adds a new field to the manifest, platformVersion. It is intended to be set to the current version of the Snaps SDK, and if set, is checked by the Snap controller to make sure the current supported version by the Snaps Platform is equal or newer than the specified platformVersion.

I've added a feature flag rejectInvalidPlatformVersion which, when enabled, will throw an error upon installation if specified platform version is too new. Otherwise it simply logs a warning in the console.

Mrtenz avatar Oct 07 '24 13:10 Mrtenz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.46%. Comparing base (dd08ed6) to head (3296c2b). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2803      +/-   ##
==========================================
+ Coverage   94.45%   94.46%   +0.01%     
==========================================
  Files         484      486       +2     
  Lines       10329    10358      +29     
  Branches     1574     1579       +5     
==========================================
+ Hits         9756     9785      +29     
  Misses        573      573              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 07 '24 16:10 codecov[bot]