metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

refactor: change vault backup option from `WHEN_UNLOCKED` to `WHEN_UNLOCKED_THIS_DEVICE_ONLY`

Open NicholasEllul opened this issue 8 months ago • 4 comments

Description

This pull request switches the vault backup option from WHEN_UNLOCKED to WHEN_UNLOCKED_THIS_DEVICE_ONLY. This is to match the intended purpose for the functionality. There are have been no indications that the current behaviour has not already been bound to the device.

  • WHEN_UNLOCKED: The data in the keychain item can be accessed only while the device is unlocked by the user.
  • WHEN_UNLOCKED_THIS_DEVICE_ONLY: Similar to WHEN_UNLOCKED, except the entry is not migrated to a new device when restoring from a backup.

Related issues

Related: https://github.com/MetaMask/accounts-planning/issues/475

Manual testing steps

  1. Lock and unlock the wallet

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

NicholasEllul avatar Jun 12 '24 15:06 NicholasEllul