metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

chore: migrate to mm webview npm registry

Open tommasini opened this issue 1 year ago • 4 comments

Description

This PR migrates react-native-webview to @metamask/react-native-webview on the webview upgrade branch branch

This is the PR of the main webview upgrade branch.

Currently with this error: image

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

tommasini avatar May 20 '24 23:05 tommasini

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 20 '24 23:05 github-actions[bot]

Failing test addressed ~here~ here.

legobeat avatar May 21 '24 00:05 legobeat

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 636 kB sethkfman

🚮 Removed packages: npm/@metamask/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar May 22 '24 10:05 socket-security[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a4436e10273976f9ed87656008f25ee53efd9b99 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60f0ea5b-b0ad-4593-8564-70cba060ebeb

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 23 '24 12:05 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 33ef1d31764aad44f4babc346335e9f5a1d7a40e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/895704f8-84bc-4e71-afd1-3348764f2211

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 23 '24 18:05 github-actions[bot]

LGTM

@sethkfman A lot of failing Android E2E tests, though...? https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/895704f8-84bc-4e71-afd1-3348764f2211

legobeat avatar May 23 '24 20:05 legobeat

They are failing on the main update branch as well, the last e2e smoke passing was April third: https://github.com/MetaMask/metamask-mobile/pull/7759/commits

So there is 12 commits to review

tommasini avatar May 23 '24 22:05 tommasini

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7e2e407abcd0148d730dfbf97bcd2af0beffdb25 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5ff6b304-7f6c-4bc6-ba32-230a1be9f6fc

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 28 '24 19:05 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ad7cee8fef1b26077abb8783cea4b74333c7ecc6 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d03f1ba-c728-4068-8a7f-8c6694b13cf3

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 31 '24 01:05 github-actions[bot]

We'll continue with the E2E work in #7759 as discussed with @tommasini today

cc @cortisiko @legobeat

jpcloureiro avatar Jun 03 '24 11:06 jpcloureiro