chore: migrate to mm webview npm registry
Description
This PR migrates react-native-webview to @metamask/react-native-webview on the webview upgrade branch branch
This is the PR of the main webview upgrade branch.
Currently with this error:
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/@metamask/[email protected] | None | 0 |
636 kB | sethkfman |
🚮 Removed packages: npm/@metamask/[email protected], npm/[email protected]
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: a4436e10273976f9ed87656008f25ee53efd9b99 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60f0ea5b-b0ad-4593-8564-70cba060ebeb
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 33ef1d31764aad44f4babc346335e9f5a1d7a40e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/895704f8-84bc-4e71-afd1-3348764f2211
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
LGTM
@sethkfman A lot of failing Android E2E tests, though...? https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/895704f8-84bc-4e71-afd1-3348764f2211
They are failing on the main update branch as well, the last e2e smoke passing was April third: https://github.com/MetaMask/metamask-mobile/pull/7759/commits
So there is 12 commits to review
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 7e2e407abcd0148d730dfbf97bcd2af0beffdb25 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5ff6b304-7f6c-4bc6-ba32-230a1be9f6fc
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: ad7cee8fef1b26077abb8783cea4b74333c7ecc6 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d03f1ba-c728-4068-8a7f-8c6694b13cf3
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
95.8% Coverage on New Code
0.0% Duplication on New Code
We'll continue with the E2E work in #7759 as discussed with @tommasini today
cc @cortisiko @legobeat