metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

chore: Upgrade react-native-svg to 15.3

Open smilingkylan opened this issue 9 months ago • 5 comments

Description

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/60/views/6?pane=issue&itemId=61547905

Manual testing steps

  1. Go to https://app.poolside.party with the in-app browser and connect the wallet
  2. Once you connect, you would see an Root Error: Text strings must be rendered within a <Text> component. error message, but now you should not see that error message... the wallet should connect just fine.

Screenshots/Recordings

Before

https://github.com/MetaMask/metamask-mobile/assets/6249205/6a58eca9-e9a0-4240-acdd-f7fb3b52f033

After

https://github.com/MetaMask/metamask-mobile/assets/6249205/d9e68e1f-6aff-42bb-9b3f-80eae8ef2e2d

Pre-merge author checklist

  • [X] I’ve followed MetaMask Coding Standards.
  • [X] I've completed the PR template to the best of my ability
  • [X] I’ve included tests if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [X] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [X] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

smilingkylan avatar May 16 '24 21:05 smilingkylan

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 16 '24 21:05 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] network +1 2.97 MB jake7

🚮 Removed packages: npm/[email protected]

View full report↗︎

socket-security[bot] avatar May 16 '24 21:05 socket-security[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 07146625c68551a5081616a5597b00553344cfc1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17cec348-8ce2-4080-a687-34bcab226cd7

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 16 '24 23:05 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3465de6d28340b4fcf0a61f0c0e46b71e93a7da1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/45f8521f-76c8-4cc4-ae3a-ed7c6f4a0e76

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 17 '24 19:05 github-actions[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar May 20 '24 15:05 socket-security[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7ef31c8f60b0799be3bda81c06236ce395e2c2ee Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/866c5556-8f38-4a6f-a09a-757944682851

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 20 '24 15:05 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 20 '24 15:05 sonarqubecloud[bot]

@SocketSecurity ignore npm/[email protected]

Latest contributor appears to be part of the organization that maintains the GitHub repo and npm package. Also contributor to other React Native projects

smilingkylan avatar May 20 '24 16:05 smilingkylan