metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

feat: increase percentage

Open salimtb opened this issue 9 months ago • 8 comments

Description

This pull request introduces a new feature to the MetaMask mobile that enhances user experience by displaying the percentage increase or decrease for each token directly within the UI. This update aims to provide users with immediate visual feedback on the performance of their tokens, helping them make more informed decisions based on recent market trends.

core PR: https://github.com/MetaMask/core/pull/4206 figma: https://www.figma.com/design/aMYisczaJyEsYl1TYdcPUL/Wallet-Assets?node-id=1620-23897&t=EJSzfKoFvTJ5LuK0-0

Related issues

Fixes: #9635

Manual testing steps

  1. Go to the wallet view
  2. You should see the percentage of increase/decrease

Screenshots/Recordings

Before

Screenshot 2024-05-15 at 16 54 25

After

Screenshot 2024-05-15 at 16 39 31

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

salimtb avatar May 15 '24 14:05 salimtb

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 15 '24 14:05 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 57a7acec9f88bc5411fa33522d6ab1f612e56eea Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/539f976a-2a6f-41ac-ae6b-1ac0d2ef1ebd

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 15 '24 16:05 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 18298dc8b420306e20aa1f8353b1c5b2da657377 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f784f85c-df77-4cd6-9f5c-a56420eb9c9f

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 95b8fd0eabbd0555250ec889b867185acccacb8b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5efb7fe1-c49f-43d7-991a-94d725752ec3

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7576968cc00bee2ef94cd33653bb87173a43e0d2 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/703edbaf-9bf2-430a-86a1-263f79cbafd5

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d08208a2961a06eb2b21d46032f8b06b27100fc7 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ee3fb08c-e313-49cb-9031-a3b4585d91ef

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 16 '24 13:05 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f4400b0ad2c8701d54ed10d7899ff02144711e21 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a802cc04-9db0-4407-a673-db77cc29d1d1

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 16 '24 15:05 github-actions[bot]

PR available here

salimtb avatar Jun 27 '24 14:06 salimtb