MetaMask
chore(devDeps): bump metro and react-native
Description
Update react-native and metro to receive patches.
- Update metro from
0.73to0.76 - Migrate from
metro-configto@react-native/metro-config - Update
react-nativefrom0.71.15to0.72.14- Port patch
- Remove hermes patch
- Bump and unpin
@react-native-community/packages - Update
@react-native-community/netinfofrom6.0.0to^9.5.0- Changelog
- Release notes
- v10 breaking change:
netinfo now requires AbortController
- Update
@react-native-masked-view/masked-view - Upgrade to Gradle version 8.0.1 and Android SDK 33
React Native Upgrade Android SDK Update
Related issues
- Fixes: https://github.com/MetaMask/mobile-planning/issues/1262
- #7759
Manual testing steps
Node environment must be 18.18.2
Supports Java version 17.0.10
- Check out branch
- Run
yarn setup - Run
yarn watch - Run
yarn start:ios- wait for app to build on iOS simulator - Run
yarn start:android- wait for app to build Android emulator
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [x] I’ve followed MetaMask Coding Standards.
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using JSDoc format if applicable
- [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action:
Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
I have read the CLA Document and I hereby sign the CLA
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.
11 out of 12 committers have signed the CLA. :white_check_mark: @legobeat :white_check_mark: @leotm :white_check_mark: @Daniel-Cross :white_check_mark: @Cal-L :white_check_mark: @tommasini :white_check_mark: @omridan159 :white_check_mark: @sethkfman :white_check_mark: @jpuri :white_check_mark: @sahar-fehri :white_check_mark: @Prithpal-Sooriya :white_check_mark: @kylanhurt :x: @Dan Cross
GitHub can't find an account for Dan Cross. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-masked-view/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]
![socket-security[bot] avatar](https://avatars.githubusercontent.com/in/156372?v=4 "Published by a pub.dev verified publisher"){kind=small}
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎
This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.
Ignoring: npm/@babel/[email protected], npm/@react-native-community/[email protected], npm/@react-native/[email protected], npm/[email protected], npm/[email protected]
Next steps
Take a deeper look at the dependency
Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.
Remove the package
If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.
Mark a package as acceptable risk
To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all
just noting we've removed old .node-version in RN 72 upstream so we may want to remove our .nvmrc too to simplify our setup if not causing any issues
just noting we've removed old .node-version in RN 72 upstream so we may want to remove our .nvmrc too to simplify our setup if not causing any issues
It's still used in GitHub Actions workflows. But in any case, it would be nice to consolidate the declaration of the project nodejs version.
We could already tell asdf to read version from .nvmrc as well: https://github.com/asdf-vm/asdf-nodejs?tab=readme-ov-file#nvmrc-and-node-version-support
They do refer to it as legacy, though. An alternative would be to replace .nvmrc with the newer .tool-versions, which @actions/setup-node also supports.
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: f7a521731f1aa9957a8be19e930b47649872b0ad Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c839fcda-58f7-4f47-aec0-98cbb6056b2b
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 00a2a88993ad7ae3943a9765a158b404fbcddaf6 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ee873da1-d949-4526-a864-1c914686e049
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@react-native-community/[email protected]
@SocketSecurity ignore npm/@react-native/[email protected]
@SocketSecurity ignore npm/[email protected]
new authors ok
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Daniel-Cross needs a
yarn deduplicate
@Daniel-Cross Again a yarn deduplicate should clear the failing ci check (:
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: cea970023e0bc11562d94fca241864042595d889 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5421866-405b-4e38-a02a-45a1dcea6c77
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 74651a298e3a056417ba7552ce7b76dee705e837 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7225238d-c316-49db-a3e8-c112088626db
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 6eb5efcb967f150afa465c3655733118a0b3dad1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6f6277e0-393c-41b0-b1e5-3ac2f741e1b3
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 138ffcebe64075f24a02d96dca672e48c8f7f9bf Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a0eec9fe-4f43-4e01-bb02-2edb0a5f06d2
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: ada906789dc9cd860924f55c18e8130365991901 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c563feb4-b100-4a25-9905-44a311bf0113
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 52b98f30168d77392ef9a9c661deeaf4ef23ed93 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f5b749ae-b43e-4637-83d6-02f486c31569
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 746fa12cb123d21c8b9ea48c3a7998f60af49de0 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/243a0bb3-7198-492c-8294-5fbde6888357
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 0d3a58f1db364733d3e455ad13b56113e8005f97 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/76d61e2d-be9d-4428-b69b-1f35b81acb42
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 2f38bc7f1bcab5aac5eacf178de6c82773caba22 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/873ec0a7-75ed-4c7a-b4f0-c22ba3916533
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: c0516b33cc767f5e65c5372201eac9e6f8002331 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f1b32806-5044-4b17-978d-070ad00a416c
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: c7129d6d4b90fbd9db095a6949cae0005464f132 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c7529a85-4e19-474f-a1dd-abe93633c22a
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 1fbf67f7b8566af10bf39f404a283b208a91d66d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a57ab6eb-9d57-4e23-8e28-6b9a5d3ea5c3
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 58e60cc69a3d93057e0ff9eff2e0bc8cf79772f1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/325b01a7-eb86-4268-9eb4-3f5802c31264
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: c364421cc2211b7f57c38b564913c803156c1f4f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/185d1e08-75e9-4cfd-80a7-9d8139d7ff09
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: f2917ddef7c1e95925dafdcc8ccb70ed4ca6923c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cee913ce-519b-4c61-ac78-95c86cc30ff3
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: a65f458a42b11fe09604583b6a0b0943b937f0f5 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5cac279c-2749-4691-af84-71cb47c9eade
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 94b61bc0183b2583ffb80230a367391b09cd257c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/924b06f3-0af0-4b1e-a653-416ab191afb7
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 7d2f111c053796a794b30e4227ceb5f10fcb5a6a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83d0e4e9-e05e-43c0-b7c1-4366b17b9261
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 7d2f111c053796a794b30e4227ceb5f10fcb5a6a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/44dc764a-453d-4ce9-bcdd-605e549d4a86
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
