metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

feat: Add new privacy policy alert toast

Open jonybur opened this issue 10 months ago • 5 comments

Description

Changes: Adds a new privacy policy banner that will show up after May 6, 2024. If the user closes it manually, the privacy policy banner will not show up again. If the user does not close the toast manually, the privacy policy banner will cease to show up after a day of being shown for the first time. Changes the Survey banner so that we can display multiple banners at the same time without overlapping each other.

Considerations:

  • Make sure this doesn't show up during onboarding
  • This toast will show up even after years of the privacy policy being changed. We should set up a deadline for that or eventually revert this PR.
  • Check if copy is correct.

Related issues

Fixes:

Manual testing steps

  1. Go to the home page
  2. Check if there's a new privacy banner there (date should be edited in the code so that the privacy policy shows up earlier than May 6, 2024)
  3. When clicking the link, it should take you to the Privacy Policy website
  4. When closing it, it shouldn't show up again
  5. If not closing it manually, the toast should not show up again after 1 day of being shown for the first time. This data is saved in localStorage so editing the timestamp there should be enough to test this feature out.

Screenshots/Recordings

https://github.com/MetaMask/metamask-mobile/assets/11148144/ae6e74fc-0a7f-47ce-8744-4a292875f7b3

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jonybur avatar Apr 11 '24 13:04 jonybur

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Apr 11 '24 13:04 github-actions[bot]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/components/Nav/App/index.js

Function Unhandled Issue
App Error: TaskQueue: Error with task : The 'navigation' object hasn't been initialized yet. This might happ... (app/component-library/comp...
Event Count: 2 Affected Users: 2

Did you find this useful? React with a 👍 or 👎

sentry-io[bot] avatar Apr 11 '24 13:04 sentry-io[bot]

@jonybur Same as for Extension, could you remove the Accept button here please? It's not required from a legal point of view and it might create the impression that it is

hesterbruikman avatar May 01 '24 09:05 hesterbruikman

I have read the CLA Document and I hereby sign the CLA

jonybur avatar May 08 '24 13:05 jonybur

Component library changes LGTM! Approving to unblock. Please still get an approval from @EtherWizard33 🙏

Also needed approval from mobile platform code owners first.

Screenshot 2024-05-09 at 2 35 31 PM

EtherWizard33 being a newcomer probably shouldn't be really stamping stuff yet.

EtherWizard33 avatar May 09 '24 20:05 EtherWizard33

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e37fd18257d06d7ebf71580ffa164536781eba09 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b93d5261-5d88-43aa-a369-5edefe5d2c0c

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 14 '24 20:05 github-actions[bot]