metamask-mobile
metamask-mobile copied to clipboard
Adapt to EIP-1193 provider changes
What is this about?
After SafeEventEmitterProvider is updated to support EIP-1193 and a new version of @metamask/eth-json-rpc-provider is released, we should adapt to the changes:
- We should upgrade
@metamask/network-controller, as that will incorporate the changes to@metamask/eth-json-rpc-provider. - At this point, calling
sendAsyncwill be deprecated; we should userequestinstead.- We re-bind
sendAsyncinEngine.ts. - We also assume that the provider has a
sendAsyncmethod inAddressElement.test.tsx.
- We re-bind
Scenario
(N/A)
Design
(N/A)
Technical Details
(Given above)
Threat Modeling Framework
(N/A)
Acceptance Criteria
(Given above)
Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
References
No response
Maybe blocked controller upgrades at the moment.