metamask-mobile feat: Move Security settings from Experimental Settings into Security Settings

trafficstars

Description

We should move security alerts feature out of Settings > Experimental to Settings > Security & Privacy under the Security section below the show private key feature.

Related issues

Fixes: #1986

Manual testing steps

Start Metamask
Open Settings > Experimental and see blockaid settings
Checkout this branch
Open Metamask
Open Settings > Security & Privacy and see blockaid settings under private key settings

Screenshots/Recordings

Before

https://github.com/MetaMask/metamask-mobile/assets/44811/0ed7131a-fcb4-4e57-b697-83496aa73d5b

After

https://github.com/MetaMask/metamask-mobile/assets/44811/2e68562d-1674-41fe-9db9-3270d1bffb9b

Pre-merge author checklist

[x] I’ve followed MetaMask Coding Standards.
[x] I've clearly explained what problem this PR is solving and how it is solved.
[x] I've linked related issues
[x] I've included manual testing steps
[x] I've included screenshots/recordings if applicable
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
[x] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Feb 20 '24 13:02 segun

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Feb 20 '24 13:02 github-actions[bot]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9d6f8ee) 41.43% compared to head (cf74584) 41.44%. Report is 2 commits behind head on main.

Files	Patch %	Lines
...ngs/SecuritySettings/Sections/BlockaidSettings.tsx	50.00%	7 Missing and 1 partial :warning:

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8635   +/-   ##
=======================================
  Coverage   41.43%   41.44%           
=======================================
  Files        1254     1256    +2     
  Lines       30565    30571    +6     
  Branches     3001     3001           
=======================================
+ Hits        12666    12671    +5     
- Misses      17146    17147    +1     
  Partials      753      753

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.