metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

7.17.0

Open github-actions[bot] opened this issue 1 year ago • 1 comments

This is the release candidate for version 7.17.0.

github-actions[bot] avatar Feb 16 '24 19:02 github-actions[bot]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 16 '24 22:02 github-actions[bot]

Changes from design system team for 7.17 should be working as expected

brianacnguyen avatar Feb 22 '24 22:02 brianacnguyen

Changes for the Accounts team are validated,

  1. https://github.com/MetaMask/metamask-mobile/pull/8414

gantunesr avatar Feb 23 '24 12:02 gantunesr

Testing iOS v.7.17.0 (1266)

Onboarding: custom ETH mainnet ✅ Custom mainnet Scenario 1 (Verifying Custom Mainnet Screen Appears): ✅ Custom mainnet Scenario 2 (Entering an Invalid Mainnet RPC URL): ✅ Custom mainnet Scenario 3 (Entering a valid mainnet RPC URL): ✅ Custom mainnet Scenario 4 (Editing a custom mainnet URL on the settings and privacy view): ✅ Custom mainnet Scenario 5 (Deleting a custom mainnet URL on the settings and privacy view): ❗Deleting RPC URL before clicking the Delete button causes the app to crash https://recordit.co/mNdFpgDM2f

QR Scanner Regression ✅ From the in-app camera I should be able to scan a valid QR code containing an address: https://recordit.co/cwoXdVikkn

✅ I should be able to use the QR scanner on the send flow to scan an address: https://recordit.co/5jRKI9lkrg

✅ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message: https://recordit.co/5vw3KTRU5d

✅ When I scan a dapp QR code using the QR scanner on the send flow I should see the appropriate error message: https://recordit.co/1druZr3DWd

❌ When I scan an invalid address QR code using the in app camera I should see the appropriate warning message: FAILED - no warning message: https://recordit.co/KyXIbe8wq5

✅ When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message: https://recordit.co/M8ORKyqraR

✅ A user can scan a private key QR code using the in-app camera to import an account: https://recordit.co/yS1KtmO0AA

✅ User scans MMM Receive QR code on different network: https://recordit.co/C32eOjGTxC

Setting: General view ✅ Scenario: Changing the device language from English to Russian: ❗ The “What’s New” pop-up has some English text. English text appears in Settings after redirect. https://recordit.co/labOJN8ae5

✅ Scenario: Changing the app language from English to Filipino: ❗ Automatically check for security updates pop-up appears twice https://recordit.co/U26g95VYD6

Browser Regression ✅ Scenario: Searching an invalid url and prompts the user with an error message: https://recordit.co/EI3w4ICAGW

✅ Scenario: Navigation with browser controls: https://recordit.co/B9E9Yc2DqR

✅ Scenario: ENS website loads correctly: https://recordit.co/8cJyWemE61

✅ Scenario: From the browser I can successfully upload a picture: https://recordit.co/abSv8lOWsg

✅ Scenario: Address bar: https://recordit.co/6Uec0C1Gf6

✅ Scenario: Adding browser Favorites: https://recordit.co/B68AIbzIo9

✅ Scenario: Browser Options Menu: Browser back button - https://recordit.co/bM5nCwdS87 Reload, Share, Network change in wallet, & New Tab - https://recordit.co/l1DPOMwVRM

✅ Scenario: Visiting a malicious website prompts the user with the phishing detection warning: https://recordit.co/3uyjyalc0C

✅ Scenario: Navigate to pancakeswap.finance and connect wallet account https://recordit.co/7lCIAZ53Ig

Network regression ✅ Scenario: I can remove a custom network (Palm) that was added via the popular network flow: ❗ "Do you want to remove this network" message doesn’t appear https://recordit.co/BCWpDBXZiu

✅ Scenario: I can remove a custom network that was added via the custom network flow. ❗ "Do you want to remove this network" message doesn’t appear https://recordit.co/vUjDPZ4JYC

✅ Scenario Outline: Adding a network via a Dapp: https://recordit.co/lpdBivadkh

✅ Scenario Outline: Adding a network via the new popular network flow: ❗ Poygon - “This network URL doesn’t match a known provider for this chain ID” appears ❗ BNB - “This network URL doesn’t match a known provider for this chain ID” & “It looks like this network’s display name doesn’t match its chain ID” appear https://recordit.co/srL9e8qCCv

✅ Scenario: Adding a network via the custom network flow: https://recordit.co/3evlIUzVFU

✅ Scenario: Adding a custom network and editing the network: https://recordit.co/hkdCKN27W8

✅ Scenario: Editing a popular network: https://recordit.co/GeTcbA7dJK

katkopel avatar Feb 25 '24 00:02 katkopel

Network Regression: ✅ Scenario: I can remove a custom network (Palm) that was added via the popular network flow: https://drive.google.com/file/d/1hU3IuWnJp-dpLtJvQJzPMyG4cS0J3Tew/view?usp=drive_link ✅ Scenario: I can remove a custom network that was added via the custom network flow. NOTE: The alert message with the text "Do you want to remove this network" does not appear https://drive.google.com/file/d/1hNP_2MhAVABdx-90Z7iKaPsKU4vMtME4/view?usp=drive_link ✅ Scenario Outline: Adding a network via a Dapp: https://drive.google.com/file/d/1hN3u2vEteYSxqO_vn3P4Dmwc6sqhZ1DO/view?usp=drive_link ✅ Scenario Outline: Adding a network via the new popular network flow: https://drive.google.com/file/d/1hMrYR9ORZbGLZ0nz3Z1xt1C0frpCbNdE/view?usp=drive_link ✅ Scenario: Adding a network via the custom network flow: https://drive.google.com/file/d/1hL0DP1Vs2KBTncnCugUn6fVLZiGc4vz5/view?usp=drive_link ✅ Scenario: Adding a custom network and editing the network: https://drive.google.com/file/d/1hGWFFP3QBkjFXtCYDiy_CbAzLROZ_Zc3/view?usp=drive_link ✅ Scenario: Editing a popular network: https://drive.google.com/file/d/1hGFHG0FxeT1CYZ3pih3E6F6oRtl8C-JQ/view?usp=drive_link

Browser Regression: ✅ Scenario: Searching an invalid url and prompts the user with an error message: https://drive.google.com/file/d/1h59b9uRlCM7jNfnT9GeXpgIXXn6mbkTL/view?usp=drive_link ✅ Scenario: Navigation with browser controls: https://drive.google.com/file/d/1h-nA5SoBUqnNrpC95_Mq6oKh6CoM0sWo/view?usp=drive_link ✅ Scenario: ENS website loads correctly: https://drive.google.com/file/d/1gyWLacLD5pN50uvu9U7t2zZ91aGOKYX-/view?usp=drive_link ✅ Scenario: From the browser I can successfully upload a picture: https://drive.google.com/file/d/1gyQxfzThGRA5dksf7IGV1rk_eJrgZnmr/view?usp=drive_link ✅ Scenario: Address bar: https://drive.google.com/file/d/1gnhuo6qkZewrUdGAzIcx1ehG-dzsmHKz/view?usp=drive_link ✅ Scenario: Adding browser Favorites: https://drive.google.com/file/d/1gnCqNPqhAOlPWmhk7iRXz9ckJ5j-yFWO/view?usp=drive_link

  • Name field was not pre populated with "Uniswap Interface"
  • At step #13, the page would not load, I had to close the tab and open a new one
  • On the favorites tab, the newly created favorite could not load the icon

✅ Scenario: Visiting a malicious website prompts the user with the phishing detection warning: https://drive.google.com/file/d/1gmbVVmnc4o3QTJPisxnbRc7jH7_cSWvr/view?usp=drive_link ✅ Scenario: Navigate to pancakeswap.finance and connect wallet account https://drive.google.com/file/d/1gjE4Fw8BuQs2woS6M8W9OktSjP2BIjRR/view?usp=drive_link ✅ Scenario: Browser Options Menu: https://drive.google.com/file/d/1gdnRA0y9Or7eW8oJkq5Sj5Xcce4vhcCm/view?usp=drive_link

Setting: General View: ✅ Scenario: Changing the device language from English to Russian: https://drive.google.com/file/d/1hnz-tmaDD0VQDB-Nn8zAYkVfUGCSHSsd/view?usp=drive_link ✅ Scenario: Changing the app language from English to Filipino: https://drive.google.com/file/d/1hjIaOyAKROqst_5Rz9n1V3rIhjnfDEFH/view?usp=drive_link

Onboarding: Custom ETH Mainnet: ✅ Custom main net Scenario 1 (Verifying Custom Mainnet Screen Appears): https://drive.google.com/file/d/1fmI4hv4qAhVAua_ET9f33CBO25bWt7Qv/view?usp=drive_link ✅ Custom main net Scenario 2 (Entering an Invalid Mainnet RPC URL): https://drive.google.com/file/d/1fhDF39GrvYl28LmXo86UNzg_DDe75e9q/view?usp=drive_link ✅ Custom main net Scenario 3 (Entering a valid Mainnet RPC URL): https://drive.google.com/file/d/1ffFnMJkk7G-d4PWNdasG4lbOjjNOWk3C/view?usp=drive_link ✅ Custom main net Scenario 4 (Editing a custom main net URL on the settings and privacy view): https://drive.google.com/file/d/1faRV8pTwyCs80D87JIi7kVB686BleFfm/view?usp=drive_link ✅ Custom main net Scenario 5 (Deleting a custom mainnet URL on the settings and privacy view): https://drive.google.com/file/d/1f_FhdjPM04tH4GqeGpCYxaGkFVyR5ROh/view?usp=drive_link

QR Scanner Regression: ✅ From the in-app camera I should be able to scan a valid QR code containing an address: https://drive.google.com/file/d/1gHQbR_WDYQWRJX2DmHp3nHUKDhdXfm0c/view?usp=drive_link ✅ I should be able to use the QR scanner on the send flow to scan an address: https://drive.google.com/file/d/1gFUkzGMKoQPKVbWFyrXvPHeytDmoylJ0/view?usp=drive_link ✅ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message: https://drive.google.com/file/d/1g3SvcePq-qo0w664DsDGNqG613KcQCk5/view?usp=drive_link ✅ When I scan a dapp QR code using the QR scanner on the send flow I should see the appropriate error message: https://drive.google.com/file/d/1g1J9IKydA22FLI5KNf5OAwOhx3UXBPR0/view?usp=drive_link ❌ When I scan an invalid address QR code using the in app camera I should see the appropriate warning message: FAILED - no warning message: https://drive.google.com/file/d/1g0eunsHFs2l7V2nQWg2Afy8Fv32gPyZ1/view?usp=drive_link ✅ When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message: https://drive.google.com/file/d/1fwidcseRirit5JSU3hS4aFCkRe4s8G9S/view?usp=drive_link ✅ A user can scan a private key QR code using the in-app camera to import an account: https://drive.google.com/file/d/1ftlvppA80jgOll0bll53dlzAFRJkf5nM/view?usp=drive_link ✅ User scans MMM Receive QR code on different network: https://drive.google.com/file/d/1gK8LmeZgwdam6AaYgEcLnhSMjy8r3nyI/view?usp=drive_link

Nick-Son avatar Feb 25 '24 21:02 Nick-Son

Changes from team-lavamoat for 7.17.0 should be working as expected (nb: this is https://github.com/MetaMask/metamask-mobile/pull/8373 already cherry-picked in 7.16.0) cc @SamuelSalas

leotm avatar Feb 26 '24 13:02 leotm

🟢 Approval on Behalf of the Hardware wallets team

After testing and consultation with the product manager, it's confirmed that none of the identified issues are launch-blocking. This approval is delivered on behalf of the Hardware wallets team, to include PR 8246 within release 7.17.0

plasmacorral avatar Feb 27 '24 15:02 plasmacorral

🟢 QA SIgn off from Team Mobile platform

✅ fix: Cherry pick translations #8773 ✅ New Crowdin translations by Github Action #8632 ✅ fix: Custom network chain id not converted to hexadecimal format #8606 ✅ fix: missing converting to decimal chain id on network verification of pop… #8592 ✅ fix: revert slice engine #8587 ✅ ci: Exclude ip package from audit #8563 ✅ fix: Commit script diff that appears when building iOS #8559 ✅ test: add blacklist URLs to automated tests #8558 ✅ test: use fast swipe on account sheet modal #8541 ✅ feat: Feature/1300 dapp visit event #8520 ✅ fix: Update MixPanel proxy URL #8517 ✅ fix: Fix/8352 source map stack trace #8509 ✅ fix: Revert "fix: Fix/8352 source map stack trace (#8467)" #8508 ✅ fix: clarify cherry pick action inputs #8500 ✅ fix: Cleanup/miscellaneous #8488 ✅ chore: bumping code coverage thresholds #8478 ✅ fix: Fix/8352 source map stack trace #8467 ✅ feat: Update assets controllers v^9.0.0 #8378 ✅ feat: Update network controller v^10 #8370 ✅ test: 1452 refactor modal pages batch 2 #8257 ✅ fix: Update navigation bar on start loading #8126 ✅ feat: chain id to hexadecimal format #7999

SamuelSalas avatar Feb 29 '24 00:02 SamuelSalas

:green_circle: This is the QA Sign Off from Confirmations UX.

Main checks

  • :green_circle: Blockaid is enabled by default both in fresh installs and migrations for android and ios
  • :green_circle: Copy for benign messages has been updated https://github.com/MetaMask/metamask-mobile/pull/8725
  • :green_circle: Origin is set to metamask for inner wallet transactions https://github.com/MetaMask/metamask-mobile/pull/8742
  • :green_circle: Friction modal has been removed for ios https://github.com/MetaMask/metamask-mobile/pull/8552

Issues

Some identified issues (non blockers):

Screenshots

https://github.com/MetaMask/metamask-mobile/assets/54408225/3578014a-66b2-449a-b94b-75f15d0c5e1f

image

https://github.com/MetaMask/metamask-mobile/assets/54408225/aa223311-55dc-4a52-81d9-ccc69c036248

seaona avatar Mar 01 '24 08:03 seaona

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a3a413e807a1da63bfa34c92d6e993db08b6fceb Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/409d8a92-38ba-4e62-9341-67c630d168ea

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Mar 01 '24 19:03 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 01 '24 19:03 sonarqubecloud[bot]

v7.17.0 build 1267 RC2 has QA Sign-off

SamuelSalas avatar Mar 01 '24 19:03 SamuelSalas