metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[Bug]: Removing the size prop in the BottomSheetFooter buttons props breaks link variant

Open georgewrmarshall opened this issue 1 year ago • 2 comments

Describe the bug

Removing the size prop in the bottomsheetfooter buttons props messes with the link variant second kinda of a blocker: disabled prop does not work

Expected behavior

Removing size prop should not break link button variant

Screenshots/Recordings

https://github.com/MetaMask/metamask-mobile/assets/8112138/d321a91e-9b41-43a7-8784-13cb5abf7636

Steps to reproduce

  1. Use the BottomSheetFooter with link variant

Error messages or log output

No response

Version

develop

Build type

None

Device

iphone

Operating system

iOS

Additional context

No response

Severity

  • Blocker for ramps

georgewrmarshall avatar Feb 15 '24 17:02 georgewrmarshall

@wachunei please add any additional information if needed

georgewrmarshall avatar Feb 19 '24 21:02 georgewrmarshall

@georgewrmarshall No more additional information needed, the code + video is straightforward

wachunei avatar Feb 20 '24 16:02 wachunei

@georgewrmarshall This is not a bug. When you remove the size variant of ButtonLink, it defaults to size Auto, which sets the ButtonLink to the inline auto size so the behavior you saw is 100% intended

brianacnguyen avatar Feb 26 '24 02:02 brianacnguyen

@brianacnguyen as discussed in our 1:1 I'll defer to your decision to leave as is and close or update BottomSheetFooter to adjust the size of the ButtonLink during the mapping of the buttonPropsArray and whether it makes sense or might just complicate the component

georgewrmarshall avatar Feb 26 '24 20:02 georgewrmarshall

Closed as ButtonLink is working as intended

brianacnguyen avatar Feb 27 '24 03:02 brianacnguyen