metamask-mobile
metamask-mobile copied to clipboard
[Bug]: Removing the size prop in the BottomSheetFooter buttons props breaks link variant
Describe the bug
Removing the size prop in the bottomsheetfooter buttons props messes with the link variant second kinda of a blocker: disabled prop does not work
Expected behavior
Removing size prop should not break link button variant
Screenshots/Recordings
https://github.com/MetaMask/metamask-mobile/assets/8112138/d321a91e-9b41-43a7-8784-13cb5abf7636
Steps to reproduce
- Use the BottomSheetFooter with link variant
Error messages or log output
No response
Version
develop
Build type
None
Device
iphone
Operating system
iOS
Additional context
No response
Severity
- Blocker for ramps
@wachunei please add any additional information if needed
@georgewrmarshall No more additional information needed, the code + video is straightforward
@georgewrmarshall This is not a bug. When you remove the size variant of ButtonLink, it defaults to size Auto, which sets the ButtonLink to the inline auto size so the behavior you saw is 100% intended
@brianacnguyen as discussed in our 1:1 I'll defer to your decision to leave as is and close or update BottomSheetFooter to adjust the size of the ButtonLink during the mapping of the buttonPropsArray
and whether it makes sense or might just complicate the component
Closed as ButtonLink is working as intended