metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

feat: migrate Segment UI class components [split of 8387 - 4]

Open NicolasMassart opened this issue 1 year ago • 2 comments

Description

[!NOTE] #8387 is too big for review, splitting it into contextual/domain scoped smaller PRs. you can refer to #8387 for global view

[!WARNING] This PR depends on PR slice 3 #8580, currently targeting feat/1462_migrate_segment_main_3 branch to allow build. Will require change once branch merged in feat/batch_1129_segment

This is the part of #8387 related to the utils code of the Segment work.

  • update UI class components to use new metrics
  • update unit tests
  • update snapshots

Related issues

Related to MetaMask/mobile-planning/issues/1461

Manual testing steps

NA

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [x] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [x] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

NicolasMassart avatar Feb 15 '24 15:02 NicolasMassart

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 15 '24 15:02 github-actions[bot]

Closed as this was reworked and split differently in smaller PRs for the migration

NicolasMassart avatar Feb 28 '24 13:02 NicolasMassart