fix: deprecate goerli network
Description
Pr to deprecate goerli network.
- Removes instances of goerli network. (From network dropdown and setting)
- Updates e2e tests to use Sepolia instead.
- Creates a new component (https://www.figma.com/file/KXgbxFucvk3FM5VULGZmzk/Assets%3A-Bug-Fixes?node-id=449%3A2210&mode=dev) for the scenario when a user clicks on a deepling for goerli.
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1368
Manual testing steps
- Click on network dropdown list (you should not see Goerli)
- Click on settings, then network list (you should not see Goerli)
- Click on a deeplink that is supposed to switch to goerli : https://metamask.app.link/send/0x4701Aa9471d7bfAc765D87dcb1Ea6BB23AD32733@5/approve?address=0x178e3e6c9f547A00E33150F7104427ea02cfc747&uint256=5e8. You should see a modal saying that the network is deprecated.
Screenshots/Recordings
Before
https://github.com/MetaMask/metamask-mobile/assets/10994169/d748b713-5157-4d00-8b85-558c1e0164a7
After
When you try to click on a deeplink with goerli
https://github.com/MetaMask/metamask-mobile/assets/10994169/622a47c3-5223-4420-84d8-a2aa3274973d
When you try to add goerli network as custom network
https://github.com/MetaMask/metamask-mobile/assets/10994169/0591d2b9-3299-44aa-9e6b-463ff66cd693
Android:
https://github.com/MetaMask/metamask-mobile/assets/10994169/13f4ef7f-adcc-4967-8036-1ceffbf0653a
https://github.com/MetaMask/metamask-mobile/assets/10994169/aa6028b1-5ab0-4063-b00f-6c47f941880f
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
Attention: Patch coverage is 52.08333% with 23 lines in your changes are missing coverage. Please review.
Project coverage is 41.39%. Comparing base (
01c6724) to head (fbe73f4).
Additional details and impacted files
@@ Coverage Diff @@
## main #8567 +/- ##
==========================================
+ Coverage 41.38% 41.39% +0.01%
==========================================
Files 1266 1269 +3
Lines 30768 30810 +42
Branches 3028 3037 +9
==========================================
+ Hits 12733 12755 +22
- Misses 17275 17293 +18
- Partials 760 762 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2070d01b-6243-400c-b975-a97e8b3594be You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/44ff88f1-5687-4778-b5fb-15fa7914bb02 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/67d6687f-a02c-489f-96fc-1cca16df87fe You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/624eab23-7413-4180-8392-015e8a2df783 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e966a10-7fcd-43ee-b56a-25d442723203 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2aef7ce1-57ed-44b8-aa6a-ba6df01a6005 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/34b1c8eb-a2b0-4b87-a06c-ac6e608d7b23 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f89cb97f-4ee4-4c74-abf0-633b48c17d75 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8f45533f-5140-4eb9-8b2a-1412c50caecb You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ab01d86d-65e1-4408-bf4d-e2137bf72e93 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/44c5ff22-c288-4069-91d4-152f832b47d1 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53f4e58d-e65d-43db-aa45-a1538f73ecd0 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9fe80d42-5803-4613-a5b5-34d5afcddd03 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/76a7206c-a686-4c7c-8571-34bb1e85bc78 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2b73d524-0292-49fe-bf8a-209600d8d8bc You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a3c317ca-53e5-427b-8d86-ab73c7aacf67 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/650575f8-f96f-47e5-88de-e4642940e001 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/934bfcac-7245-4333-9def-f6a23efc4af8 You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
Have we also tested upgrading with Goerli network selected?
Hey @Cal-L , i have tested the migration when the user is already on goerli, he will be automatically switched to Sepolia 🙏
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aee20f90-de37-4eef-8535-7f8ba47c25fb You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ae14b4f2-691d-407d-b4ac-146a549429ea You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e7479fd-947d-4703-9ee6-f362a6226afd You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label
Quality Gate passed
Issues
0 New issues
Measures
0 Security Hotspots
62.5% Coverage on New Code
0.0% Duplication on New Code