metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[Bug]:Company Logo is not displayed in connect wallet popup

Open davidli108 opened this issue 1 year ago • 3 comments

Describe the bug

When I click Connect Wallet button in my website (iPhone, chrome browser), I am redirected to metamask app and connect wallet popup is displayed. But the logo is no displayed in that popup and I only see the first letter of site origin. After I checking your codebase, you are getting the favIcon to display the logo in useFavIcon hook. But seems like this hook is not working properly.

Expected behavior

The logo should be displayed properly

Screenshots/Recordings

No response

Steps to reproduce

  1. Go to https://app.cibola.finance on iphone
  2. Click Connect Wallet button and redirect to metamask app
  3. ConnectWallet popup is displayed but the logo is not displayed. Instead A is shown

Error messages or log output

No response

Version

v7.15.0 (1245)

Build type

None

Device

Any iphone

Operating system

iOS

Additional context

Inside app/util/favicon/index.ts file, please check fetchHtmlSource method I think fetch function returns cors error sometimes

Severity

No response

davidli108 avatar Feb 06 '24 12:02 davidli108

Hey @davidli108 ! Thank you for reporting this issue! The team is looking into it!

ZbrancaI avatar Feb 08 '24 15:02 ZbrancaI

Hi! For connect wallet, i used Web3Modal and i resolved this issue after upgrading web3Modal to v4

davidli108 avatar Feb 08 '24 16:02 davidli108

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar May 08 '24 16:05 github-actions[bot]

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

github-actions[bot] avatar May 15 '24 17:05 github-actions[bot]