metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[Bug]: Missing Translation for Biometric Authentication Feature in Canadian English Localization

Open rmashate opened this issue 2 years ago • 4 comments

Describe the bug

Users with the Canadian English (en-CA) locale experience a missing translation error when attempting to enable biometric authentication in the application. The error message displayed is "[missing "en-CA.biometrics.enable_fac translation]".

Expected behavior

The application should display a Canadian English translation for enabling biometric authentication, allowing the user to unlock the wallet using facial recognition.

Screenshots/Recordings

Screenshot_20231128-210515

Steps to reproduce

Open the application. Navigate to the login screen. Observe the error message in the biometric authentication section.

Error messages or log output

missing "en-CA.biometrics.enable_face translation

Version

7.11

Build type

None

Device

Google Pixel 4

Operating system

Android

Additional context

Ensure that all language keys are correctly implemented in the application's i18n (internationalization) files. Add a missing translation string for "en-CA.biometrics.enable_fac" in the relevant localization file.

Severity

No response

rmashate avatar Nov 29 '23 02:11 rmashate

Potential updates to the localization file

"biometrics": {
    "enable_touchid": "Unlock with Touch ID?",
    "enable_faceid": "Unlock with Face ID?",
    "enable_fingerprint": "Unlock with Fingerprint?",
    "enable_biometrics": "Unlock with Biometrics?",
    "enable_device_passcode_ios": "Unlock with device passcode?",
    "enable_device_passcode_android": "Unlock with device PIN?",
    "en-CA.biometrics.enable_face": "Unlock with Face ID?"
},

rmashate avatar Nov 29 '23 03:11 rmashate

Hello, @rmashate. Thanks for reporting! I will pass this on to the team.

anaamolnar avatar Nov 29 '23 09:11 anaamolnar

Even if translation is missing, it shall fallback to english.

gauthierpetetin avatar Feb 07 '24 16:02 gauthierpetetin

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar May 07 '24 16:05 github-actions[bot]

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

github-actions[bot] avatar May 14 '24 16:05 github-actions[bot]

I tested it and was not able to reproduce with what we currently have on main: image image

However, the only way to reproduce is to actually remove the string from the en.json file so that it's not available for any english variant and then it will display the error when your language is Canadian English (en-CA) image

But this string has been in the en.json since 848daebbeb40d97683ea9dbc4018af92581c518f (2018) so I see no reason for it to suddenly fail on version 7.11 as reported in the issue. Unless the RN translation system is completely broken or something else made it fail, I don't see any reason to worry. It works as expected. I also confirm the fallback to english works, I removed the string from the french file and text is properly displayed in english by default: image

NicolasMassart avatar May 14 '24 22:05 NicolasMassart

Thanks a lot for the investigation @NicolasMassart!

gauthierpetetin avatar May 15 '24 04:05 gauthierpetetin