metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[STO] Consolidate reducers & action creators with RTK: alert

Open MarioAslau opened this issue 2 years ago • 1 comments

What is this about?

As part of or ongoing effort to use Redux Toolkit to consolidate reducers and action creators we will continue using Redux Tool Kit to consolidate them into slices + remove the need for multiple files.

For this ticket, we'll focus on alert actions and reducers into a slice file using RTK.

Scenario

No response

Design

No response

Technical Details

Same type of implementation as https://www.notion.so/Redux-Toolkit-Performance-Upgrade-b10cb97d7ed44dfaa15b522951971037

Threat Modeling Framework

No response

Acceptance Criteria

  • These changes do not affect the UX of the app but will require a full e2e test to ensure flows are still working.

    • In addition to the pr_smoke_e2e_pipeline running, trigger the pr_regression_e2e_pipeline
    • Run the build_android_qa workflow so we trigger the app launch times tests as well.
  • New slice is still able to consume and dispatch data using RTK slices

  • Ensure that alert data is still persisted

  • Reach out to @Andepande or @cortisiko on what the acceptance criteria might look like. @Cal-L would recommend that since there's no functional changes and the data remains the same, this can be classified as No QA + Run Smoke E2E + Provide recording showing that the area in the app still works.

References

Implementation of RTK: https://www.notion.so/Redux-Toolkit-Performance-Upgrade-b10cb97d7ed44dfaa15b522951971037

MarioAslau avatar Nov 16 '23 16:11 MarioAslau

Hey team! Please add your planning poker estimate with Zenhub @Cal-L @chrisleewilcox @frankvonhoven @NicolasMassart @SamuelSalas @tommasini

cortisiko avatar Nov 21 '23 00:11 cortisiko