metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

chore: fix typos

Open shuoer86 opened this issue 2 years ago • 11 comments

Description

Fix typos

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

shuoer86 avatar Nov 11 '23 03:11 shuoer86

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Nov 11 '23 03:11 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

shuoer86 avatar Nov 11 '23 03:11 shuoer86

if you could preserve the original PR template too, that would be great

leotm avatar Nov 16 '23 13:11 leotm

@leotm Thanks for you review.

shuoer86 avatar Nov 16 '23 15:11 shuoer86

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (93ce2e2) 40.21% compared to head (f59b589) 40.21%. Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7764   +/-   ##
=======================================
  Coverage   40.21%   40.21%           
=======================================
  Files        1234     1234           
  Lines       29883    29883           
  Branches     2862     2862           
=======================================
  Hits        12017    12017           
  Misses      17175    17175           
  Partials      691      691           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 29 '23 15:11 codecov-commenter

@georgewrmarshall I would like to add code speller workflow in CI if needed

shuoer86 avatar Dec 05 '23 15:12 shuoer86

@georgewrmarshall @brianacnguyen @leotm thanks for your reviews again.

shuoer86 avatar Dec 26 '23 15:12 shuoer86

@brianacnguyen Could you help to merge it? Thank you very much.

shuoer86 avatar Jan 12 '24 14:01 shuoer86

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Apr 11 '24 23:04 github-actions[bot]

@georgewrmarshall @brianacnguyen @leotm

I rebased to resolved the new coming conflict.

Please help me to review again. Thank you very much!

shuoer86 avatar Apr 12 '24 16:04 shuoer86

@georgewrmarshall @brianacnguyen @leotm Could you help to merge when approved.

shuoer86 avatar May 17 '24 11:05 shuoer86

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 15 '24 12:08 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 13 '24 17:11 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Feb 12 '25 21:02 github-actions[bot]