Vault Corruption Flow: Users who already imported their wallet are prompted with the "Protect your wallet modal"

[cortisiko]

Describe the bug If a user goes through the vault corruption flow while having an imported wallet, they are prompted with the Protect your wallet modal even though they already imported their wallet. The protect your wallet modal should only appear for new wallets not imported wallets.

Screenshots See recording here compared to new wallet users who are not prompted with the Protect your wallet modal.

To Reproduce Install v6.6 (1114) Import your wallet Update the app to 7.1 (1125) Notice the vault corruption flow is triggered. Kill the app install v7.4.1 (1161) This is the build with the fix. After entering your password and going through the vault corruption flow, The protect your wallet modal is triggered.

Expected behavior The Protect your wallet modal should not be displayed with users who imported their wallet.

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• App Version [e.g. 1.0.0] - find version number in app from Settings > About MetaMask

---

to be added after bug submission by internal support / PM Severity

• How critical is the impact of this bug on a user?
• Add stats if available on % of customers impacted
• Is this visible to all users?
• Is this tech debt?

[sethkfman]

@cortisiko I think this bug is resolved. Can you confirm and close?

[cortisiko]

@sethkfman This is still not resolved. We decided the issue reported above is not a blocker for the original vault corruption fix: https://github.com/MetaMask/metamask-mobile/pull/6957

See slack thread here: https://consensys.slack.com/archives/C05HRMJU9R7/p1692120674274269?thread_ts=1692109563.239589&cid=C05HRMJU9R7

[plasmacorral]

Just experienced this on v7.5.0 build 1167, Android 13. Had remember me enabled and active, was promoted for password at launch and then completed recovery flow successfully. SRP backup demand made app unusable until I confirmed the SRP that was previously imported prior to vault recovery.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

[github-actions[bot]]

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.