metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[fix] Surface WalletConnect errors to user

Open amytang0 opened this issue 3 years ago • 2 comments

Description

Currently, there is no feedback for when a connection is broken/can't be connected to. For example, hitting a dead session currently has no feedback from Metamask, and users end up confused about what steps to take. This shows an alert dialog to let users know potential next steps to take.

This also refactors the wallet connect code a little so that all 3 paths benefit from the error handling UI. Screenshots/Recordings

Screen Shot 2022-09-07 at 10 53 52 AM

Issue

Progresses #???

Checklist

  • [ ] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

amytang0 avatar Sep 07 '22 18:09 amytang0

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA. :x: @amytang0

github-actions[bot] avatar Sep 07 '22 18:09 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

amytang0 avatar Sep 07 '22 18:09 amytang0

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Jun 04 '23 21:06 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity. Thank you for your contributions.

github-actions[bot] avatar Jun 14 '23 14:06 github-actions[bot]