metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Fix crash on reading QR code wallet connect twice

Open tommasini opened this issue 3 years ago • 1 comments

Description Throwing the error of the sessions already existed was crashing the app.

Proposed Solution Prompt notification to inform the user he already has an existing session instead of throwing the error.

(There was another solution, we could keep throwing the error, and catch the error when the new session was being created, but it seemed to me that had no advantage in this case)

Code impact Low

Test Cases Open wallet connect on the web, https://example.walletconnect.org/

  • Take a print screen of the QR code
  • Paste the print screen somewhere else
  • Read the Qr code with the metamask mobile app
  • Read it again

Screenshots/Recordings

Issue

Progresses #4855

Checklist

  • [ ] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

tommasini avatar Sep 02 '22 18:09 tommasini

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Sep 02 '22 18:09 github-actions[bot]

Closing this PR because was merged here

tommasini avatar Sep 29 '22 13:09 tommasini