BNB: "Submitted" transactions are not updating to "Completed" when blockchain shows success

[chrisleewilcox]

Updated Description: "Submitted" transactions are not updating to "Confirmed" when blockchain shows success on block explorer.

"Submitted" transactions are not updating to "Completed" when blockchain shows success on Binance mainnet. When transaction is in this stated the "Speed Up" and "Cancel" will always show popup for retry but retry fails because transactions is already completed.

https://recordit.co/PrmH6nkGiB

[chrisleewilcox]

Related issue: https://app.zenhub.com/workspaces/mobile-qa-board-6249fe41701a8f001195ca64/issues/metamask/metamask-mobile/4804

https://github.com/MetaMask/metamask-mobile/pull/4804

[blackdevelopa]

I am unable to reproduce this for days now and will like to move it back to our backlog for whenever it happens again. I am certain the challenge isn't with the code (mobile or controller), but with the RPCProvider (https://bsc-dataseed1.binance.org) we use for BSC (not Infura parsed). There's little or nothing we can do at this time to fix this and from observing the logs, it updates itself after sometime.

What really happens? We use the eth_getTransactionByHash method in our controllers code to check when a transaction has been added to a block (that is confirmed). Ideally, it returns the block number alongside other important details. For this bug (that is random), it doesn't return the block number even though transaction is now confirmed. Since the controller code doesn't get the block number, the mobile app doesn't.

@chris.wilcox can we close this PR until it happens again?

[chrisleewilcox]

Was not able to reproduce with new refactor changes from 4835